From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] First cut at libifying revlist generation
Date: Sun, 26 Feb 2006 19:19:13 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0602261914270.22647@g5.osdl.org> (raw)
In-Reply-To: <7vpsl93395.fsf@assigned-by-dhcp.cox.net>
On Sun, 26 Feb 2006, Junio C Hamano wrote:
>
> I am clueless about the "limited = (list && list->next)" part,
> but there is only one commit involved hence the test is false
> with my testcase "git-rev-list --objects v1.0.0^0..v1.0.0"; I
> think the old code said dotdot is a limited case.
dotdot should insert _two_ commits onto the list - the positive and
the negative one. Doesn't it?
So the
if (list && list->next)
check should be correct. If we have just one entry, there's no reason to
do everything up-front, we can just run with it (and get the nice
streaming behaviour).
> -static struct object_list *pending_objects = NULL;
> -
> - for (pending = pending_objects; pending; pending = pending->next) {
> + for (pending = revs.pending_objects; pending; pending = pending->next) {
But this part is obviously correct. I already sent out the same patch a
minute ago ;)
> - if (revs.max_age || revs.min_age)
> + if (revs.max_age != -1 || revs.min_age != -1)
As is this. I for a while had zero meaning "no age", and I actually think
it probably should be that way, but then we'd have to switch the
date-related functions around, which is why I decided not to do it after
all (but missed this one that I had already written for that case).
Linus
next prev parent reply other threads:[~2006-02-27 3:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-26 0:19 [PATCH] First cut at libifying revlist generation Linus Torvalds
2006-02-26 3:40 ` Junio C Hamano
2006-02-27 1:57 ` Johannes Schindelin
2006-02-27 3:05 ` Linus Torvalds
2006-02-27 3:11 ` Junio C Hamano
2006-02-27 3:19 ` Linus Torvalds [this message]
2006-02-27 5:09 ` Junio C Hamano
2006-02-27 5:20 ` Linus Torvalds
2006-02-27 16:54 ` Linus Torvalds
2006-02-27 23:55 ` Junio C Hamano
2006-02-27 9:00 ` Johannes Schindelin
2006-02-28 1:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0602261914270.22647@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).