From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Junio C Hamano <junkio@cox.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] First cut at libifying revlist generation
Date: Mon, 27 Feb 2006 02:57:19 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.63.0602270257110.4147@wbgn013.biozentrum.uni-wuerzburg.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0602251608160.22647@g5.osdl.org>
Hi,
beware of that patch. It breaks at least one thing: cloning a repository
with a tag pointing to a tag object (the tag is cloned, but not the tag
object).
Sorry to not fix it right away, but I am just too tired.
By way of figuring this out, I just found a (warning: irony) "cute
feature" of git-bisect. I needed to apply a certain patch to trigger a
certain bug. So I always applied that patch after bisect chose the next
rev, and of course committed it so that bisect could continue.
(In hindsight, I probably should've applied the patch,
git-update-index'ed the file, and hoped that the merge mechanism take care
of it.)
Now, short of finding the correct commit, bisect would loop endlessly,
giving me the same rev to test over and over again (saying "2 revs to go
after this"), because I would label the current rev (which was the applied
patch, not the bad rev) as bad.
So, in a very real sense, it might not be such a phantastic idea as was
suggested earlier on this list, that you are able to commit on top of a
bisected rev.
Good night and good luck,
Dscho
next prev parent reply other threads:[~2006-02-27 1:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-26 0:19 [PATCH] First cut at libifying revlist generation Linus Torvalds
2006-02-26 3:40 ` Junio C Hamano
2006-02-27 1:57 ` Johannes Schindelin [this message]
2006-02-27 3:05 ` Linus Torvalds
2006-02-27 3:11 ` Junio C Hamano
2006-02-27 3:19 ` Linus Torvalds
2006-02-27 5:09 ` Junio C Hamano
2006-02-27 5:20 ` Linus Torvalds
2006-02-27 16:54 ` Linus Torvalds
2006-02-27 23:55 ` Junio C Hamano
2006-02-27 9:00 ` Johannes Schindelin
2006-02-28 1:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.63.0602270257110.4147@wbgn013.biozentrum.uni-wuerzburg.de \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).