git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, pasky@ucw.cz
Subject: Re: [PATCH 0/1] Diff-helper update
Date: Wed, 18 May 2005 11:38:46 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0505181134470.18337@ppc970.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0505181110480.18337@ppc970.osdl.org>



On Wed, 18 May 2005, Linus Torvalds wrote:
> 
> If diff-helper just passes the lines it doesn't understand through
> unmodified (_after_ having handled any pending rename logic), it will 
> automatically do the right thing.

I took the liberty of doing just that. The only subtle issue was that 
the strbuf functions would consider an empty line to be EOF, which looked 
wrong and unintentional. Fixing that made the actual diff-helper changes 
totally trivial, and I can now do

	git-rev-list HEAD | git-diff-tree -r -v --stdin | ./git-diff-helper -r | less -S

and it does the right thing for me.

		Linus

  reply	other threads:[~2005-05-18 18:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-18  6:28 [PATCH 0/1] Diff-helper update Junio C Hamano
2005-05-18 15:41 ` Linus Torvalds
2005-05-18 17:58   ` Junio C Hamano
2005-05-18 18:14     ` Linus Torvalds
2005-05-18 18:38       ` Linus Torvalds [this message]
2005-05-18 18:52         ` Thomas Glanzmann
2005-05-18 20:30         ` Junio C Hamano
2005-05-18 20:39           ` Linus Torvalds
2005-05-18 23:54             ` Junio C Hamano
2005-05-19 11:11               ` Junio C Hamano
2005-05-19  2:05       ` [preview] diff-helper rename detection Junio C Hamano
2005-05-19  3:01         ` Linus Torvalds
2005-05-19  3:08           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0505181134470.18337@ppc970.osdl.org \
    --to=torvalds@osdl.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=pasky@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).