--jobs=0 no longer does any work

--jobs=0 no longer does any work

[Drew Noakes]

What did you do before the bug happened? (Steps to reproduce your issue)

- Enter a repo with multiple remotes
- Run: git fetch --all --prune --jobs=0

What did you expect to happen? (Expected behavior)

- Multiple remotes to be fetched in parallel

What happened instead? (Actual behavior)

- Nothing fetched and command exits quickly with no output

What's different between what you expected and what actually happened?

- That command used to work correctly. It now does nothing.

Anything else you want to add:

- The git-config documentation says of zero jobs in "fetch.parallel" that "A value of 0 will give some reasonable default. If unset, it defaults to 1.".
- This started happening after I updated my version of Git for Windows earlier today.
- Excluding the --jobs argument or passing a non-zero value works as expected.

Please review the rest of the bug report below.
You can delete any lines you don't wish to share.

[System Info]
git version:
git version 2.39.2.windows.1
cpu: x86_64
built from commit: a82fa99b36ddfd643e61ed45e52abe314687df67
sizeof-long: 4
sizeof-size_t: 8
shell-path: /bin/sh
feature: fsmonitor--daemon
uname: Windows 10.0 22621 
compiler info: gnuc: 12.2
libc info: no libc information available
$SHELL (typically, interactive shell): C:\Program Files\Git\usr\bin\bash.exe

[Enabled Hooks]

Re: --jobs=0 no longer does any work

[Johannes Schindelin]

Hi Drew,

On Fri, 17 Feb 2023, Drew Noakes wrote:

> What did you do before the bug happened? (Steps to reproduce your issue)
>
> - Enter a repo with multiple remotes
> - Run: git fetch --all --prune --jobs=0
>
> What did you expect to happen? (Expected behavior)
>
> - Multiple remotes to be fetched in parallel
>
> What happened instead? (Actual behavior)
>
> - Nothing fetched and command exits quickly with no output
>
> What's different between what you expected and what actually happened?
>
> - That command used to work correctly. It now does nothing.

This should be fixed via
https://github.com/git/git/commit/d180cc297922569e530da843bee4df3964167dea
which made it into v2.40.0, unless I am mistaken. Could you verify?

Ciao,
Johannes

Re: --jobs=0 no longer does any work

[Drew Noakes]

Hi Johannes,

Fix verified in 2.40.0. Thank you for restoring this behaviour.

Best,
Drew.

-----Original Message-----
From: Johannes Schindelin <Johannes.Schindelin@gmx.de> 
Sent: Monday, March 27, 2023 8:19 PM
To: Drew Noakes <drnoakes@microsoft.com>
Cc: git@vger.kernel.org
Subject: Re: --jobs=0 no longer does any work

Hi Drew,

On Fri, 17 Feb 2023, Drew Noakes wrote:

> What did you do before the bug happened? (Steps to reproduce your issue)
>
> - Enter a repo with multiple remotes
> - Run: git fetch --all --prune --jobs=0
>
> What did you expect to happen? (Expected behavior)
>
> - Multiple remotes to be fetched in parallel
>
> What happened instead? (Actual behavior)
>
> - Nothing fetched and command exits quickly with no output
>
> What's different between what you expected and what actually happened?
>
> - That command used to work correctly. It now does nothing.

This should be fixed via
https://github.com/git/git/commit/d180cc297922569e530da843bee4df3964167dea
which made it into v2.40.0, unless I am mistaken. Could you verify?

Ciao,
Johannes