From: serg.partizan@gmail.com To: Stefan Haller <stefan@haller-berlin.de> Cc: me@yadavpratyush.com, git@vger.kernel.org Subject: Re: [PATCH] git-gui: use gray selection background for inactive text\r widgets Date: Mon, 23 Nov 2020 22:08:05 +0200 Message-ID: <HLM9KQ.QZTOWNY8EICB1@gmail.com> (raw) In-Reply-To: <23d6eb6c-4c7b-b9dd-d0df-fe0feaa0dc17@haller-berlin.de> On Mon, Nov 23, 2020 at 20:03, Stefan Haller <stefan@haller-berlin.de> wrote: >>> + bind $i <FocusIn> { >>> + foreach tag [list in_diff in_sel] { >>> + %W tag conf $tag \ >>> + -background $color::select_bg \ >>> + -foreground $color::select_fg >>> + } >>> + } >>> + bind $i <FocusOut> { >>> + foreach tag [list in_diff in_sel] { >> >> This two `foreach` can be combined into one? > > I don't see how; any concrete suggestions? But I have other ideas how > to > simplify the code (by using one function set_selection_colors that > takes > a has_focus bool and is used for both bindings). I tried to do this, and now i understand why my suggestion was wrong, i was looking at this as "cycle inside cycle", but it's actually "cycle inside event handler". > >>> + %W tag conf $tag \ >> >> And this `%W`, probably should be `$i`? > > No, $i wouldn't work because we're inside curly braces, so $i wouldn't > get expanded. It would be possible to work around this by using "" > instead of {}, but why? Using %W seems to be the idiomatic way in > bindings, we do this everywhere else too. Oh, now i see it's used in the same way in other places! > %W The path name of the window to which the event was reported (the window field from the event). Now I understand it.
next prev parent reply other threads:[~2020-11-23 20:30 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-24 15:48 [PATCH] git-gui: Basic dark mode support Serg Tereshchenko 2020-08-25 19:01 ` Matthias Aßhauer 2020-09-22 11:04 ` Pratyush Yadav 2020-09-26 14:54 ` [PATCH v2] " Serg Tereshchenko 2020-10-07 11:07 ` Pratyush Yadav 2020-10-08 8:24 ` [PATCH] " Serg Tereshchenko 2020-10-08 13:07 ` [PATCH v2] " Pratyush Yadav 2020-11-21 17:47 ` Stefan Haller 2020-11-22 12:30 ` serg.partizan 2020-11-22 13:32 ` [PATCH] git-gui: Fix selected text colors Serg Tereshchenko 2020-11-22 15:41 ` Stefan Haller 2020-11-22 17:16 ` serg.partizan 2020-11-23 11:48 ` [PATCH] git-gui: use gray selection background for inactive text widgets Stefan Haller 2020-11-23 13:13 ` serg.partizan 2020-11-23 19:03 ` Stefan Haller 2020-11-23 20:08 ` serg.partizan [this message] 2020-11-29 17:40 ` Stefan Haller 2020-11-30 13:41 ` serg.partizan 2020-11-30 18:08 ` [PATCH] git-gui: use gray selection background for inactive text?? widgets Pratyush Yadav 2020-11-30 20:18 ` [PATCH] git-gui: use gray selection background for inactive text widgets Stefan Haller 2020-11-30 20:18 ` [PATCH] git-gui: keep showing selection when diff view gets deactivated on Mac Stefan Haller 2020-11-23 19:03 ` [PATCH] git-gui: Fix selected text colors Stefan Haller 2020-11-23 20:50 ` serg.partizan 2020-11-24 21:19 ` Stefan Haller 2020-11-24 21:23 ` [PATCH v2] git-gui: use gray background for inactive text widgets Stefan Haller 2020-12-17 21:49 ` Pratyush Yadav 2020-12-17 22:14 ` Stefan Haller 2020-12-18 12:50 ` Pratyush Yadav 2020-12-18 13:01 ` Stefan Haller 2020-12-18 9:43 ` [PATCH v3] " Stefan Haller 2020-12-18 12:51 ` Pratyush Yadav 2020-12-18 19:46 ` Pratyush Yadav 2020-12-17 20:23 ` [PATCH] git-gui: Fix selected text colors Pratyush Yadav 2020-10-07 11:13 ` [PATCH] git-gui: Basic dark mode support Pratyush Yadav 2020-10-08 8:20 ` Serg Tereshchenko 2020-10-08 8:28 ` Pratyush Yadav 2020-10-08 8:44 ` Serg Tereshchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=HLM9KQ.QZTOWNY8EICB1@gmail.com \ --to=serg.partizan@gmail.com \ --cc=git@vger.kernel.org \ --cc=me@yadavpratyush.com \ --cc=stefan@haller-berlin.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git