From: Stefan Haller <stefan@haller-berlin.de> To: serg.partizan@gmail.com Cc: git@vger.kernel.org, me@yadavpratyush.com Subject: Re: [PATCH] git-gui: Fix selected text colors Date: Tue, 24 Nov 2020 22:19:59 +0100 Message-ID: <55348fbb-95bb-1dd2-4e17-4fc622ae7603@haller-berlin.de> (raw) In-Reply-To: <NKO9KQ.ECZZ8I6WPK063@gmail.com> On 23.11.20 21:50, serg.partizan@gmail.com wrote: > > > On Mon, Nov 23, 2020 at 20:03, Stefan Haller <stefan@haller-berlin.de> > wrote: >> The problem is that it needs to be recalculated when the >> theme changes, and I have trouble testing that because the >> <<ThemeChanged>> event doesn't appear to be sent on Mac, as far as I can >> see. > > How are you testing this? By changing the Appearance setting from Light to Dark or back in Mac's preferences window. The git gui window does update dynamically when you do this. However, I think I was wrong when I assumed that this would change the theme; there's only one theme on Mac, the "aqua" theme. It just changes its colors, it seems. > So you can safely put your code inside "color::sync_with_theme". Will do; I'll send out v2 in a moment. > And We should move call to sync_with_theme from git-gui.sh into > InitTheme. I don't know why I have not put it there before. Yes, I was wondering this too. But as it doesn't seem to make a difference in practice, I'll leave this for someone else to fix at some point.
next prev parent reply other threads:[~2020-11-24 22:20 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-24 15:48 [PATCH] git-gui: Basic dark mode support Serg Tereshchenko 2020-08-25 19:01 ` Matthias Aßhauer 2020-09-22 11:04 ` Pratyush Yadav 2020-09-26 14:54 ` [PATCH v2] " Serg Tereshchenko 2020-10-07 11:07 ` Pratyush Yadav 2020-10-08 8:24 ` [PATCH] " Serg Tereshchenko 2020-10-08 13:07 ` [PATCH v2] " Pratyush Yadav 2020-11-21 17:47 ` Stefan Haller 2020-11-22 12:30 ` serg.partizan 2020-11-22 13:32 ` [PATCH] git-gui: Fix selected text colors Serg Tereshchenko 2020-11-22 15:41 ` Stefan Haller 2020-11-22 17:16 ` serg.partizan 2020-11-23 11:48 ` [PATCH] git-gui: use gray selection background for inactive text widgets Stefan Haller 2020-11-23 13:13 ` serg.partizan 2020-11-23 19:03 ` Stefan Haller 2020-11-23 20:08 ` serg.partizan 2020-11-29 17:40 ` Stefan Haller 2020-11-30 13:41 ` serg.partizan 2020-11-30 18:08 ` [PATCH] git-gui: use gray selection background for inactive text?? widgets Pratyush Yadav 2020-11-30 20:18 ` [PATCH] git-gui: use gray selection background for inactive text widgets Stefan Haller 2020-11-30 20:18 ` [PATCH] git-gui: keep showing selection when diff view gets deactivated on Mac Stefan Haller 2020-11-23 19:03 ` [PATCH] git-gui: Fix selected text colors Stefan Haller 2020-11-23 20:50 ` serg.partizan 2020-11-24 21:19 ` Stefan Haller [this message] 2020-11-24 21:23 ` [PATCH v2] git-gui: use gray background for inactive text widgets Stefan Haller 2020-12-17 21:49 ` Pratyush Yadav 2020-12-17 22:14 ` Stefan Haller 2020-12-18 12:50 ` Pratyush Yadav 2020-12-18 13:01 ` Stefan Haller 2020-12-18 9:43 ` [PATCH v3] " Stefan Haller 2020-12-18 12:51 ` Pratyush Yadav 2020-12-18 19:46 ` Pratyush Yadav 2020-12-17 20:23 ` [PATCH] git-gui: Fix selected text colors Pratyush Yadav 2020-10-07 11:13 ` [PATCH] git-gui: Basic dark mode support Pratyush Yadav 2020-10-08 8:20 ` Serg Tereshchenko 2020-10-08 8:28 ` Pratyush Yadav 2020-10-08 8:44 ` Serg Tereshchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55348fbb-95bb-1dd2-4e17-4fc622ae7603@haller-berlin.de \ --to=stefan@haller-berlin.de \ --cc=git@vger.kernel.org \ --cc=me@yadavpratyush.com \ --cc=serg.partizan@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) This inbox may be cloned and mirrored by anyone: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 git git/ https://public-inbox.org/git \ git@vger.kernel.org public-inbox-index git Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: https://80x24.org/mirrors/git.git AGPL code for this site: git clone https://public-inbox.org/public-inbox.git