From: "Philip Oakley" <philipoakley@iee.org>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "GitList" <git@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] Help.c use OPT_COUNTUP
Date: Mon, 4 Mar 2013 00:31:33 -0000 [thread overview]
Message-ID: <F455D17A40C2498C84F85E2937B732AC@PhilipOakley> (raw)
In-Reply-To: 7v4ngsyqpx.fsf@alter.siamese.dyndns.org
From: "Junio C Hamano" <gitster@pobox.com>
Sent: Monday, March 04, 2013 12:05 AM
> "Philip Oakley" <philipoakley@iee.org> writes:
>
>>> Hrm, I do not recall anybody ever declared that "--all" is
>>> deprecated.
>>
>> No, it was the use OPT_COUNTUP rather than OPT_BOOLEAN that the
>> deprecated' was refering to.
>
> Oh, no OPT_BOOLEAN was deprecated because too many people rightfully
> thought it was about 0/1 choice and got burned by its count-up
> behaviour. When you want to count-up, OPT_COUNTUP is the right
> thing to do and replacing deprecated BOOLEAN with it is a correct
> thing to do. But for this optoin, I do not think you want to count
> up in the first place. You want a 0/1 choice, which is written as
> OPT_BOOL these days.
Ah, I missed that.
Though, for the longer term --guides usage, I'd envisaged that having it
a second time could be used to invoke some extra search code that would
list all guides, rather than just the short list of common guides. But
I'm not sure how best to determine what are valid guides, including
Msysgit/Git4Windows which only uses the html versions (no man command),
so I'll use OPT_BOOL initially.
Philip
next prev parent reply other threads:[~2013-03-04 0:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-03 20:21 [PATCH v2 0/5] Git help option to list user guides Philip Oakley
2013-03-03 20:21 ` [PATCH v2 1/5] Show 'git help <guide>' usage, with examples Philip Oakley
2013-03-03 23:38 ` Junio C Hamano
2013-03-03 20:21 ` [PATCH v2 2/5] Help.c use OPT_COUNTUP Philip Oakley
2013-03-03 23:38 ` Junio C Hamano
2013-03-03 23:54 ` Philip Oakley
2013-03-04 0:05 ` Junio C Hamano
2013-03-04 0:31 ` Philip Oakley [this message]
2013-03-03 20:21 ` [PATCH v2 3/5] Help.c add --guide option Philip Oakley
2013-03-03 23:38 ` Junio C Hamano
2013-03-04 0:04 ` Philip Oakley
2013-03-03 20:21 ` [PATCH v2 4/5] Help.c: add list_common_guides_help() function Philip Oakley
2013-03-03 20:21 ` [PATCH v2 5/5] Help doc: Include --guide option description Philip Oakley
2013-03-03 23:39 ` Junio C Hamano
2013-03-04 0:18 ` Philip Oakley
-- strict thread matches above, loose matches on Subject: below --
2013-03-03 23:44 [PATCH v2 0/5] [RESEND with Cc:] Git help option to list user guides Philip Oakley
2013-03-03 23:44 ` [PATCH v2 2/5] Help.c use OPT_COUNTUP Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F455D17A40C2498C84F85E2937B732AC@PhilipOakley \
--to=philipoakley@iee.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).