From: Junio C Hamano <gitster@pobox.com>
To: Philip Oakley <philipoakley@iee.org>
Cc: GitList <git@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] Help.c use OPT_COUNTUP
Date: Sun, 03 Mar 2013 15:38:22 -0800 [thread overview]
Message-ID: <7vwqtoyryp.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 1362342072-1412-3-git-send-email-philipoakley@iee.org
Philip Oakley <philipoakley@iee.org> writes:
> rename deprecated option in preparation for 'git help --guides'.
s/rename/Rename/;
>
> Signed-off-by: Philip Oakley <philipoakley@iee.org>
> ---
Hrm, I do not recall anybody ever declared that "--all" is deprecated.
I do not think we want --all and --all --all to be different, and we
certainly do not want --all --no-all to be not-all, so I cannot tell
what you want to achieve with this change at all, either from the
patch or the proposed log message.
> builtin/help.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/help.c b/builtin/help.c
> index d1d7181..d10cbed 100644
> --- a/builtin/help.c
> +++ b/builtin/help.c
> @@ -39,7 +39,7 @@ static int show_all = 0;
> static unsigned int colopts;
> static enum help_format help_format = HELP_FORMAT_NONE;
> static struct option builtin_help_options[] = {
> - OPT_BOOLEAN('a', "all", &show_all, N_("print all available commands")),
> + OPT_COUNTUP('a', "all", &show_all, N_("print all available commands")),
> OPT_SET_INT('m', "man", &help_format, N_("show man page"), HELP_FORMAT_MAN),
> OPT_SET_INT('w', "web", &help_format, N_("show manual in web browser"),
> HELP_FORMAT_WEB),
next prev parent reply other threads:[~2013-03-03 23:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-03 20:21 [PATCH v2 0/5] Git help option to list user guides Philip Oakley
2013-03-03 20:21 ` [PATCH v2 1/5] Show 'git help <guide>' usage, with examples Philip Oakley
2013-03-03 23:38 ` Junio C Hamano
2013-03-03 20:21 ` [PATCH v2 2/5] Help.c use OPT_COUNTUP Philip Oakley
2013-03-03 23:38 ` Junio C Hamano [this message]
2013-03-03 23:54 ` Philip Oakley
2013-03-04 0:05 ` Junio C Hamano
2013-03-04 0:31 ` Philip Oakley
2013-03-03 20:21 ` [PATCH v2 3/5] Help.c add --guide option Philip Oakley
2013-03-03 23:38 ` Junio C Hamano
2013-03-04 0:04 ` Philip Oakley
2013-03-03 20:21 ` [PATCH v2 4/5] Help.c: add list_common_guides_help() function Philip Oakley
2013-03-03 20:21 ` [PATCH v2 5/5] Help doc: Include --guide option description Philip Oakley
2013-03-03 23:39 ` Junio C Hamano
2013-03-04 0:18 ` Philip Oakley
-- strict thread matches above, loose matches on Subject: below --
2013-03-03 23:44 [PATCH v2 0/5] [RESEND with Cc:] Git help option to list user guides Philip Oakley
2013-03-03 23:44 ` [PATCH v2 2/5] Help.c use OPT_COUNTUP Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwqtoyryp.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).