From: Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/5] t/t5800: skip if python version is older than 2.5
Date: Wed, 02 Jun 2010 10:15:23 -0500 [thread overview]
Message-ID: <ECbjGSsMA4ZIaSU1sgkRHSvxlxbZZwsEBdVFoyCTLeEuJTxU_EI8Xw@cipher.nrlssc.navy.mil> (raw)
In-Reply-To: <meC0HM60UnAajjHuTX-y8qZO2Unmc9VZYk1ZAHZ86LlKSy4E9Rfc_w@cipher.nrlssc.navy.mil>
On 06/02/2010 09:44 AM, Brandon Casey wrote:
> On 06/02/2010 01:21 AM, Sverre Rabbelier wrote:
>> Heya,
>>
>> On Wed, Jun 2, 2010 at 02:13, Brandon Casey <casey@nrlssc.navy.mil> wrote:
>>> This test script depends on the git-remote-testgit python script. This
>>> python script makes use of the hashlib module which was released in python
>>> version 2.5. So, add a new pre-requisite named PYTHON_2_5_OR_NEWER to
>>> test-lib.sh and check for it in t5800.
>> Perhaps instead we can change git-remote-testgit to do:
>>
>> "try:
>> import hashlib
>> except ImportError:
>> import ?? as hashlib
>> "
>
> I can only guess at what that does. :)
Correction, I have no idea what that does.
Here's the patch:
diff --git a/git-remote-testgit.py b/git-remote-testgit.py
index 9253922..1371497 100644
--- a/git-remote-testgit.py
+++ b/git-remote-testgit.py
@@ -1,6 +1,9 @@
#!/usr/bin/env python
-import hashlib
+try:
+ import hashlib
+except ImportError:
+ import ?? as hashlib
import sys
import os
sys.path.insert(0, os.getenv("GITPYTHONLIB","."))
I get:
File "<snip>/git-remote-testgit", line 6
import ?? as hashlib
^
SyntaxError: invalid syntax
next prev parent reply other threads:[~2010-06-02 15:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 0:13 [PATCH 0/5] miscellaneous test suite fixes Brandon Casey
2010-06-02 0:13 ` [PATCH 1/5] t/t5800: skip if python version is older than 2.5 Brandon Casey
2010-06-02 6:21 ` Sverre Rabbelier
2010-06-02 9:33 ` Ævar Arnfjörð Bjarmason
2010-06-02 14:44 ` Brandon Casey
2010-06-02 15:15 ` Brandon Casey [this message]
2010-06-02 16:38 ` Sverre Rabbelier
2010-06-02 16:50 ` Brandon Casey
2010-06-02 23:23 ` test suite work-around for python 2.5 requirement Brandon Casey
2010-06-02 23:23 ` [PATCH 1/2] Makefile: add PYTHON_PATH to GIT-BUILD-OPTIONS Brandon Casey
2010-06-02 23:23 ` [PATCH 2/2] t/t5800: skip if python version is older than 2.5 Brandon Casey
2010-08-17 23:15 ` Sverre Rabbelier
2010-08-17 23:28 ` Jonathan Nieder
2010-08-17 23:32 ` Sverre Rabbelier
2010-08-17 23:37 ` Jonathan Nieder
2010-08-18 0:10 ` Sverre Rabbelier
2010-08-18 2:37 ` Brandon Casey
2010-06-02 6:37 ` [PATCH 1/5] " Johannes Sixt
2010-06-02 14:46 ` Brandon Casey
2010-06-02 0:13 ` [PATCH 2/5] git-request-pull.sh: remove -e switch to shell interpreter which breaks ksh Brandon Casey
2010-06-02 4:30 ` Jonathan Nieder
2010-06-02 14:21 ` Brandon Casey
2010-06-02 23:37 ` Junio C Hamano
2010-06-02 0:13 ` [PATCH 3/5] t/t5150: remove space from sed script Brandon Casey
2010-06-02 4:12 ` Jonathan Nieder
2010-06-02 0:13 ` [PATCH 4/5] t/t7006: ignore return status of shell's unset builtin Brandon Casey
2010-06-02 5:47 ` Jonathan Nieder
2010-06-02 6:41 ` Johannes Sixt
2010-06-02 14:47 ` Brandon Casey
2010-06-02 15:32 ` [PATCH 4/5 v2] " Brandon Casey
2010-06-02 0:13 ` [PATCH 5/5] t/aggregate-results: accomodate systems with small max argument list length Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ECbjGSsMA4ZIaSU1sgkRHSvxlxbZZwsEBdVFoyCTLeEuJTxU_EI8Xw@cipher.nrlssc.navy.mil \
--to=brandon.casey.ctr@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).