git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Brandon Casey <drafnel@gmail.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	Brandon Casey <casey@nrlssc.navy.mil>,
	git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/2] t/t5800: skip if python version is older than 2.5
Date: Tue, 17 Aug 2010 21:37:26 -0500	[thread overview]
Message-ID: <AANLkTi=y5vr25cJMfV=7KisCB7R-s7YVonc-7QZemO0j@mail.gmail.com> (raw)
In-Reply-To: <AANLkTim+YQHxkY6WWF4Yfo74jZnAE8ufdnabp9mneBgu@mail.gmail.com>

On Tue, Aug 17, 2010 at 7:10 PM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
> Heya,
>
> On Tue, Aug 17, 2010 at 18:37, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> I see.  Maybe this is fixed by v1.7.2-rc0~33^2~1 (Makefile: add
>> PYTHON_PATH to GIT-BUILD-OPTIONS, 2010-06-09) from later in the
>> same series.

Well not actually the same series.  If I recall correctly, the
original version of
this 'skip if python vers...' patch was replaced by a resend of two patches and
one of them did the' propagate PYTHON_PATH to GIT-BUILD-OPTIONS' thing.

I think Junio ended up fixing up the original patch by hand, and the PYTHON_PATH
bit got dropped.

Later on I resent it.

> Ah, correct. So that should have gone before this one. It works if I
> check out and build that one. Thanks.

Also, note that the test should complete successfully if run via 'make
test' since
PYTHON_PATH is exported in the Makefile.  That's why I didn't notice the
flaw at first.

-Brandon

  reply	other threads:[~2010-08-18  2:37 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-02  0:13 [PATCH 0/5] miscellaneous test suite fixes Brandon Casey
2010-06-02  0:13 ` [PATCH 1/5] t/t5800: skip if python version is older than 2.5 Brandon Casey
2010-06-02  6:21   ` Sverre Rabbelier
2010-06-02  9:33     ` Ævar Arnfjörð Bjarmason
2010-06-02 14:44     ` Brandon Casey
2010-06-02 15:15       ` Brandon Casey
2010-06-02 16:38         ` Sverre Rabbelier
2010-06-02 16:50           ` Brandon Casey
2010-06-02 23:23     ` test suite work-around for python 2.5 requirement Brandon Casey
2010-06-02 23:23     ` [PATCH 1/2] Makefile: add PYTHON_PATH to GIT-BUILD-OPTIONS Brandon Casey
2010-06-02 23:23     ` [PATCH 2/2] t/t5800: skip if python version is older than 2.5 Brandon Casey
2010-08-17 23:15       ` Sverre Rabbelier
2010-08-17 23:28         ` Jonathan Nieder
2010-08-17 23:32           ` Sverre Rabbelier
2010-08-17 23:37             ` Jonathan Nieder
2010-08-18  0:10               ` Sverre Rabbelier
2010-08-18  2:37                 ` Brandon Casey [this message]
2010-06-02  6:37   ` [PATCH 1/5] " Johannes Sixt
2010-06-02 14:46     ` Brandon Casey
2010-06-02  0:13 ` [PATCH 2/5] git-request-pull.sh: remove -e switch to shell interpreter which breaks ksh Brandon Casey
2010-06-02  4:30   ` Jonathan Nieder
2010-06-02 14:21     ` Brandon Casey
2010-06-02 23:37       ` Junio C Hamano
2010-06-02  0:13 ` [PATCH 3/5] t/t5150: remove space from sed script Brandon Casey
2010-06-02  4:12   ` Jonathan Nieder
2010-06-02  0:13 ` [PATCH 4/5] t/t7006: ignore return status of shell's unset builtin Brandon Casey
2010-06-02  5:47   ` Jonathan Nieder
2010-06-02  6:41   ` Johannes Sixt
2010-06-02 14:47     ` Brandon Casey
2010-06-02 15:32       ` [PATCH 4/5 v2] " Brandon Casey
2010-06-02  0:13 ` [PATCH 5/5] t/aggregate-results: accomodate systems with small max argument list length Brandon Casey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=y5vr25cJMfV=7KisCB7R-s7YVonc-7QZemO0j@mail.gmail.com' \
    --to=drafnel@gmail.com \
    --cc=casey@nrlssc.navy.mil \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).