From: "Philip Oakley" <philipoakley@iee.org>
To: "Junio C Hamano" <gitster@pobox.com>,
"Stefan Beller" <sbeller@google.com>
Cc: "git" <git@vger.kernel.org>, "Kevin Daudt" <me@ikke.info>,
"Jacob Keller" <jacob.keller@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 6/7] builtin/describe.c: describe a blob
Date: Mon, 6 Nov 2017 23:50:03 -0000 [thread overview]
Message-ID: <D199FB1260C4462ABFC1F0F77D26EF06@PhilipOakley> (raw)
In-Reply-To: xmqqlgjlkzmm.fsf@gitster.mtv.corp.google.com
From: "Junio C Hamano" <gitster@pobox.com>
Sent: Sunday, November 05, 2017 6:28 AM
> "Philip Oakley" <philipoakley@iee.org> writes:
>
>> Is this not also an alternative case, relative to the user, for the
>> scenario where the user has an oid/sha1 value but does not know what
>> it is, and would like to find its source and type relative to the
>> `describe` command.
>
> I am not sure what you wanted to say with "source and type RELATIVE TO
> the describe command".
The 'relative to' was meaning the user's expectation about this particular
command. For a non-expert user, who may not have come across cat-file yet,
their world view may not extend beyond 'Git describe <this>' for me.
>
> The first thing the combination of the user and the describe command
> would do when the user has a 40-hex string would be to do the
> equivalent of "cat-file -t" to learn if it even exists and what its
> type is. With Stefan's patch, that is what describe command does in
> order to choose quite a different codeflow from the traditional mode
> when it learns that it was given a blob.
I realised, after sending, that this was probably the method for
non-ambiguous shortened oid's. Thanks for the reminder.
>
>> IIUC the existing `describe` command only accepts <commit-ish> values,
>> and here we are extending that to be even more inclusive, but at the
>> same time the options become more restricted.
>
> Do you mean that the command should check if it was given an option
> that would not be applicable to the "find a commit that has the
> blob" mode, once it learns that it was given a blob and needs to go
> in that codepath? I think that would make sense.
Correct, it was the option selection aspect.
>
>> Or have I misunderstood how the fast commit search and the slower
>> potentially-a-blob searching are disambiguated?
>
> I do not think so. We used to barf when we got anything but
> commit-ish, but Stefan's new code kicks in if the object turns out
> to be a blob---I think that is what you mean by the disambiguation.
Correct. We ask to describe an object, but then the option choices may vary
by type.
The new [blob] synopys only lists <options>, while the old [commit-ish]
shows specifics. It wasn't clear if the options are the same for both. I
quess they are the same once the cat-file -t has done its bit. Its only the
speed that's affected.
As a side note, the commit message example don't show any pathspec that is
not in the top level directory.
--
Philip
next prev parent reply other threads:[~2017-11-06 23:50 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-28 0:44 [RFC PATCH 0/3] git-describe <blob> ? Stefan Beller
2017-10-28 0:45 ` [PATCH 1/3] list-objects.c: factor out traverse_trees_and_blobs Stefan Beller
2017-10-28 0:45 ` [PATCH 2/3] revision.h: introduce blob/tree walking in order of the commits Stefan Beller
2017-10-28 17:20 ` Johannes Schindelin
2017-10-29 3:22 ` Stefan Beller
2017-10-29 3:23 ` Stefan Beller
2017-10-29 3:43 ` Junio C Hamano
2017-10-28 0:45 ` [PATCH 3/3] builtin/describe: describe blobs Stefan Beller
2017-10-28 17:32 ` Johannes Schindelin
2017-10-28 22:47 ` Jacob Keller
2017-10-29 3:28 ` Stefan Beller
2017-10-29 12:02 ` Kevin Daudt
2017-10-29 12:07 ` Johannes Schindelin
2017-10-28 17:15 ` [PATCH 1/3] list-objects.c: factor out traverse_trees_and_blobs Johannes Schindelin
2017-10-29 3:13 ` Stefan Beller
2017-10-28 16:04 ` [RFC PATCH 0/3] git-describe <blob> ? Johannes Schindelin
2017-10-31 0:33 ` [PATCH 0/7] git-describe <blob> Stefan Beller
2017-10-31 0:33 ` [PATCH 1/7] list-objects.c: factor out traverse_trees_and_blobs Stefan Beller
2017-10-31 6:07 ` Junio C Hamano
2017-10-31 0:33 ` [PATCH 2/7] revision.h: introduce blob/tree walking in order of the commits Stefan Beller
2017-10-31 6:57 ` Junio C Hamano
2017-10-31 18:12 ` Stefan Beller
2017-10-31 0:33 ` [PATCH 3/7] builtin/describe.c: rename `oid` to avoid variable shadowing Stefan Beller
2017-10-31 8:15 ` Jacob Keller
2017-10-31 0:33 ` [PATCH 4/7] builtin/describe.c: print debug statements earlier Stefan Beller
2017-10-31 7:03 ` Junio C Hamano
2017-10-31 19:05 ` Stefan Beller
2017-10-31 0:33 ` [PATCH 5/7] builtin/describe.c: factor out describe_commit Stefan Beller
2017-10-31 0:33 ` [PATCH 6/7] builtin/describe.c: describe a blob Stefan Beller
2017-10-31 6:25 ` Junio C Hamano
2017-10-31 19:16 ` Stefan Beller
2017-11-01 3:34 ` Junio C Hamano
2017-11-01 20:58 ` Stefan Beller
2017-11-02 1:53 ` Junio C Hamano
2017-11-02 4:23 ` Junio C Hamano
2017-11-04 21:15 ` Philip Oakley
2017-11-05 6:28 ` Junio C Hamano
2017-11-06 23:50 ` Philip Oakley [this message]
2017-11-09 20:30 ` Stefan Beller
2017-11-10 0:25 ` Philip Oakley
2017-11-10 1:24 ` Junio C Hamano
2017-11-10 22:44 ` [PATCH 0/1] describe a blob: with better docs Stefan Beller
2017-11-10 22:44 ` [PATCH] builtin/describe.c: describe a blob Stefan Beller
2017-11-13 1:33 ` Junio C Hamano
2017-11-14 23:37 ` Stefan Beller
2017-11-20 15:22 ` [PATCH 6/7] " Philip Oakley
2017-11-20 18:18 ` Philip Oakley
2017-11-01 3:44 ` Junio C Hamano
2017-10-31 0:33 ` [PATCH 7/7] t6120: fix typo in test name Stefan Beller
2017-11-01 1:21 ` Junio C Hamano
2017-11-01 18:13 ` Stefan Beller
2017-11-02 1:36 ` Junio C Hamano
2017-10-31 21:18 ` [PATCHv2 0/7] git describe blob Stefan Beller
2017-10-31 21:18 ` [PATCHv2 1/7] list-objects.c: factor out traverse_trees_and_blobs Stefan Beller
2017-11-01 3:46 ` Junio C Hamano
2017-10-31 21:18 ` [PATCHv2 2/7] revision.h: introduce blob/tree walking in order of the commits Stefan Beller
2017-11-01 3:50 ` Junio C Hamano
2017-11-01 12:26 ` Johannes Schindelin
2017-11-01 12:37 ` Junio C Hamano
2017-11-01 19:37 ` Stefan Beller
2017-11-01 22:08 ` Johannes Schindelin
2017-11-01 22:19 ` Stefan Beller
2017-11-01 22:39 ` Johannes Schindelin
2017-11-01 22:46 ` Stefan Beller
2017-11-01 21:36 ` Johannes Schindelin
2017-11-01 21:39 ` Jeff King
2017-11-01 22:33 ` Johannes Schindelin
2017-11-02 1:20 ` Junio C Hamano
2017-10-31 21:18 ` [PATCHv2 3/7] builtin/describe.c: rename `oid` to avoid variable shadowing Stefan Beller
2017-10-31 21:18 ` [PATCHv2 4/7] builtin/describe.c: print debug statements earlier Stefan Beller
2017-10-31 21:31 ` Eric Sunshine
2017-10-31 21:18 ` [PATCHv2 5/7] builtin/describe.c: factor out describe_commit Stefan Beller
2017-10-31 21:18 ` [PATCHv2 6/7] builtin/describe.c: describe a blob Stefan Beller
2017-10-31 21:49 ` Eric Sunshine
2017-11-01 19:51 ` Stefan Beller
2017-11-01 4:11 ` Junio C Hamano
2017-11-01 12:32 ` Johannes Schindelin
2017-11-01 17:59 ` Stefan Beller
2017-11-01 21:05 ` Jacob Keller
2017-11-01 22:12 ` Johannes Schindelin
2017-11-01 22:21 ` Stefan Beller
2017-11-01 22:41 ` Johannes Schindelin
2017-11-01 22:53 ` Stefan Beller
2017-11-02 6:05 ` Jacob Keller
2017-11-03 5:18 ` Junio C Hamano
2017-11-03 6:55 ` Jacob Keller
2017-11-03 15:02 ` Junio C Hamano
2017-11-02 7:23 ` Andreas Schwab
2017-11-02 18:18 ` Stefan Beller
2017-11-03 12:05 ` Johannes Schindelin
2017-11-01 21:28 ` Stefan Beller
2017-10-31 21:18 ` [PATCHv2 7/7] t6120: fix typo in test name Stefan Beller
2017-11-01 5:14 ` [PATCHv2 0/7] git describe blob Junio C Hamano
2017-11-02 19:41 ` [PATCHv3 " Stefan Beller
2017-11-02 19:41 ` [PATCHv3 1/7] t6120: fix typo in test name Stefan Beller
2017-11-02 19:41 ` [PATCHv3 2/7] list-objects.c: factor out traverse_trees_and_blobs Stefan Beller
2017-11-02 19:41 ` [PATCHv3 3/7] revision.h: introduce blob/tree walking in order of the commits Stefan Beller
2017-11-14 19:52 ` Jonathan Tan
2017-11-02 19:41 ` [PATCHv3 4/7] builtin/describe.c: rename `oid` to avoid variable shadowing Stefan Beller
2017-11-02 19:41 ` [PATCHv3 5/7] builtin/describe.c: print debug statements earlier Stefan Beller
2017-11-14 19:55 ` Jonathan Tan
2017-11-14 20:00 ` Stefan Beller
2017-11-02 19:41 ` [PATCHv3 6/7] builtin/describe.c: factor out describe_commit Stefan Beller
2017-11-02 19:41 ` [PATCHv3 7/7] builtin/describe.c: describe a blob Stefan Beller
2017-11-14 20:02 ` Jonathan Tan
2017-11-14 20:40 ` Stefan Beller
2017-11-14 21:17 ` Jonathan Tan
2017-11-03 0:23 ` [PATCHv3 0/7] git describe blob Jacob Keller
2017-11-03 1:46 ` Junio C Hamano
2017-11-03 2:29 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D199FB1260C4462ABFC1F0F77D26EF06@PhilipOakley \
--to=philipoakley@iee.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=me@ikke.info \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).