From: "Robin Jarry" <robin@jarry.cc>
To: phillip.wood@dunelm.org.uk, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: <git@vger.kernel.org>, "Tim Culverhouse" <tim@timculverhouse.com>,
"Nicolas Dichtel" <nicolas.dichtel@6wind.com>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Michael Strawbridge" <michael.strawbridge@amd.com>
Subject: Re: [PATCH v2] hooks: add sendemail-validate-series
Date: Tue, 11 Apr 2023 12:39:59 +0200 [thread overview]
Message-ID: <CRTV2BVL0265.1H9OALXHPDZF1@ringo> (raw)
In-Reply-To: <9b8d6cc4-741a-5081-d5de-df0972efec37@gmail.com>
Phillip Wood, Apr 11, 2023 at 11:58:
> A hook that wants to check some property of the whole series needs to
> know which patch is the final one. We could pass that via the
> environment as we do for external diff commands with
> GIT_DIFF_PATH_COUNTER and GIT_DIFF_PATH_TOTAL.
That may be an appropriate solution and it would avoid adding another
hook. And it would solve the issue of "\n" in filenames.
The only downside is that you would need to store state in an external
file (maybe in GIT_DIR) so that successive calls of the hook script can
pick up where the previous invocation ended.
It all comes down to ergonomics at this point. I don't mind either
solutions as long as validating whole series is possible before sending
emails.
next prev parent reply other threads:[~2023-04-11 10:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 18:56 [PATCH RESEND] hooks: add sendemail-validate-series Robin Jarry
2023-04-03 0:17 ` Eric Sunshine
2023-04-03 14:09 ` Phillip Wood
2023-04-03 14:32 ` Robin Jarry
2023-04-03 15:20 ` Phillip Wood
2023-04-03 15:42 ` Junio C Hamano
2023-04-03 17:25 ` Robin Jarry
2023-04-03 22:29 ` Robin Jarry
2023-04-03 22:52 ` Junio C Hamano
2023-04-03 22:59 ` Robin Jarry
2023-04-04 20:14 ` Junio C Hamano
2023-04-05 8:31 ` Robin Jarry
2023-04-05 21:49 ` Junio C Hamano
2023-04-05 23:13 ` [PATCH v2] " Robin Jarry
2023-04-06 8:56 ` Ævar Arnfjörð Bjarmason
2023-04-11 9:58 ` Phillip Wood
2023-04-11 10:39 ` Robin Jarry [this message]
2023-04-11 15:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CRTV2BVL0265.1H9OALXHPDZF1@ringo \
--to=robin@jarry.cc \
--cc=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=michael.strawbridge@amd.com \
--cc=nicolas.dichtel@6wind.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=sunshine@sunshineco.com \
--cc=tim@timculverhouse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).