From: "Robin Jarry" <robin@jarry.cc>
To: "Junio C Hamano" <gitster@pobox.com>,
"Phillip Wood" <phillip.wood123@gmail.com>
Cc: <git@vger.kernel.org>, "Tim Culverhouse" <tim@timculverhouse.com>,
"Nicolas Dichtel" <nicolas.dichtel@6wind.com>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH RESEND] hooks: add sendemail-validate-series
Date: Mon, 03 Apr 2023 19:25:42 +0200 [thread overview]
Message-ID: <CRNAOLZTJKEN.3G96UM2HO763B@ringo> (raw)
In-Reply-To: <xmqqo7o59dlz.fsf@gitster.g>
Junio C Hamano, Apr 03, 2023 at 17:42:
> I do not know why we need another hook to do pretty much the same
> thing as the existing one (which could be taught to spool and then the
> last round to validate, in addition to each step rejecting incoming
> one as needed), but at least calling it there would be very much in
> line with the existing one, I would say.
If for example the validation would require trying to apply patches on
top of another branch in a temp repository, you would need to know the
number of patches and be able to determine whether you need to reset the
branch (patch 1/N) before applying. For that you would need to parse the
contents of the patches. This is not the end of the world but I assumed
that it would be easier to handle with a hook that fires once with all
patch files.
Another option would be to change sendemail-validate to be called only
once with all patches. That would be the ideal solution since the
existing hook is not always usable with series. But that would be
a breaking change. I personally don't mind a small breakage like this
but I don't know what is the project's policy.
next prev parent reply other threads:[~2023-04-03 17:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 18:56 [PATCH RESEND] hooks: add sendemail-validate-series Robin Jarry
2023-04-03 0:17 ` Eric Sunshine
2023-04-03 14:09 ` Phillip Wood
2023-04-03 14:32 ` Robin Jarry
2023-04-03 15:20 ` Phillip Wood
2023-04-03 15:42 ` Junio C Hamano
2023-04-03 17:25 ` Robin Jarry [this message]
2023-04-03 22:29 ` Robin Jarry
2023-04-03 22:52 ` Junio C Hamano
2023-04-03 22:59 ` Robin Jarry
2023-04-04 20:14 ` Junio C Hamano
2023-04-05 8:31 ` Robin Jarry
2023-04-05 21:49 ` Junio C Hamano
2023-04-05 23:13 ` [PATCH v2] " Robin Jarry
2023-04-06 8:56 ` Ævar Arnfjörð Bjarmason
2023-04-11 9:58 ` Phillip Wood
2023-04-11 10:39 ` Robin Jarry
2023-04-11 15:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CRNAOLZTJKEN.3G96UM2HO763B@ringo \
--to=robin@jarry.cc \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nicolas.dichtel@6wind.com \
--cc=phillip.wood123@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=tim@timculverhouse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).