From: "Robin Jarry" <robin@jarry.cc>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org,
"Nicolas Dichtel" <nicolas.dichtel@6wind.com>,
"Jan Smets" <jan.smets@nokia.com>,
"Stephen Morton" <stephen.morton@nokia.com>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH v2] receive-pack: ignore SIGPIPE while reporting status to client
Date: Tue, 09 Nov 2021 22:38:45 +0100 [thread overview]
Message-ID: <CFLKOIVJ8EX0.2PWQ6PCXZ340A@diabtop> (raw)
In-Reply-To: <xmqqzgqd11dp.fsf@gitster.g>
Hi Junio,
Junio C Hamano, Nov 09, 2021 at 22:10:
> All of the above talks about the pre-receive hook, but it is unclear
> how that is relevant to this change. The first paragraph says
> "... is not killed", and if that was a bad thing (in other words, it
> should be killed but is not, and that is a bug worth fixing), and if
> this patch changes the behaviour, then that paragraph is worth
> saying. Similarly for the other two.
>
> > Before running the post-receive hook, status info is reported back to
> > the client. Since the client has died, receive-pack is killed by SIGPIPE
> > and post-receive is never executed.
>
> In other words, regardless of what happens (or does not happen) to
> the pre-receive hook, which may not even exist, if "git push" dies
> before the post-receive hook runs, this paragraph applies, no?
>
> What I am getting at is that this can (and should) be the first
> paragraph of the description without losing clarity.
You're right. I wanted to give context to better explain why
receive-pack is not killed while running the pre-receive hook but
afterwards. This should go into another commit which fixes that issue.
I will reword accordingly.
> > execute_commands(commands, unpack_status, &si,
> > &push_options);
> > + sigchain_push(SIGPIPE, SIG_IGN);
> > if (pack_lockfile)
> > unlink_or_warn(pack_lockfile);
>
> Shouldn't we start ignoring SIGPIPE here, not before we try to
> unlink the lockfile?
I initially wanted to avoid getting SIGPIPE'd while printing a warning
if the lockfile cannot be unlinked. Maybe this means the repository
integrity is compromised and we are well beyond ensuring post-receive is
executed or not. I do not know git internals well enough to be sure.
What do you think?
--
Robin
next prev parent reply other threads:[~2021-11-09 21:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 13:35 [RFC PATCH] receive-pack: run post-receive before reporting status Robin Jarry
2021-11-06 5:03 ` Ævar Arnfjörð Bjarmason
2021-11-06 21:32 ` Robin Jarry
2021-11-06 22:03 ` [PATCH v2] receive-pack: ignore SIGPIPE while reporting status to client Robin Jarry
2021-11-09 21:10 ` Junio C Hamano
2021-11-09 21:38 ` Robin Jarry [this message]
2021-11-09 23:03 ` Junio C Hamano
2021-11-10 10:35 ` [RFC PATCH] receive-pack: interrupt pre-receive when client disconnects Robin Jarry
2021-12-29 14:21 ` Robin Jarry
2021-11-10 9:29 ` [PATCH v3] receive-pack: ignore SIGPIPE while reporting status to client Robin Jarry
2021-11-18 9:36 ` Robin Jarry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CFLKOIVJ8EX0.2PWQ6PCXZ340A@diabtop \
--to=robin@jarry.cc \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jan.smets@nokia.com \
--cc=nicolas.dichtel@6wind.com \
--cc=peff@peff.net \
--cc=stephen.morton@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).