git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Robin Jarry" <robin.jarry@6wind.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: <git@vger.kernel.org>,
	"Nicolas Dichtel" <nicolas.dichtel@6wind.com>,
	"Jan Smets" <jan.smets@nokia.com>,
	"Stephen Morton" <stephen.morton@nokia.com>,
	"Jeff King" <peff@peff.net>
Subject: Re: [RFC PATCH] receive-pack: run post-receive before reporting status
Date: Sat, 06 Nov 2021 22:32:38 +0100	[thread overview]
Message-ID: <CFJ0O7HEP2TY.NSQD8094SYCF@diabtop> (raw)
In-Reply-To: <211106.86y261g88n.gmgdl@evledraar.gmail.com>

Hi Ævar,

Ævar Arnfjörð Bjarmason, Nov 06, 2021 at 06:03:
> FWIW we include the date when mentioning commits. E.g. ec7dbd145bd
> (receive-pack: allow hooks to ignore its standard input stream,
> 2014-09-12).

OK, noted.

> I think the discussion at [1] is current to everything you're seeing
> here.

Thanks I had missed this thread.

> tl;dr: Even with this change you're not guaranteed to run your hook.
[snip]
> But as noted in [1] there's a way forward to having our cake & eating it
> too. I.e. when we into that on the server-side we can try a little
> harder not to die, and run post-receive anyway, and in either case it
> would be nice if we'd run it after disconnecting from the client, so it
> doesn't have to wait for it.

OK, I will try to propose a v2 masking SIGPIPE when reporting status to
the client to avoid dying before running post-receive.

Cheers,

-- 
Robin

  reply	other threads:[~2021-11-06 21:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 13:35 [RFC PATCH] receive-pack: run post-receive before reporting status Robin Jarry
2021-11-06  5:03 ` Ævar Arnfjörð Bjarmason
2021-11-06 21:32   ` Robin Jarry [this message]
2021-11-06 22:03 ` [PATCH v2] receive-pack: ignore SIGPIPE while reporting status to client Robin Jarry
2021-11-09 21:10   ` Junio C Hamano
2021-11-09 21:38     ` Robin Jarry
2021-11-09 23:03       ` Junio C Hamano
2021-11-10 10:35     ` [RFC PATCH] receive-pack: interrupt pre-receive when client disconnects Robin Jarry
2021-12-29 14:21       ` Robin Jarry
2021-11-10  9:29   ` [PATCH v3] receive-pack: ignore SIGPIPE while reporting status to client Robin Jarry
2021-11-18  9:36     ` Robin Jarry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CFJ0O7HEP2TY.NSQD8094SYCF@diabtop \
    --to=robin.jarry@6wind.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jan.smets@nokia.com \
    --cc=nicolas.dichtel@6wind.com \
    --cc=peff@peff.net \
    --cc=stephen.morton@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).