From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: daniels@umanovskis.se, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 0/2] branch: introduce --current display option
Date: Wed, 10 Oct 2018 05:42:52 -0400 [thread overview]
Message-ID: <CAPig+cToXS+pT4Kp0uejtRkvJdSmso9a_Q=Odrhox5htzqBvTw@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cTp-cFKX2Kqj-yV7OtgmxDo7Mp7i0TUXU7JGYdgtbHiug@mail.gmail.com>
On Wed, Oct 10, 2018 at 5:29 AM Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Tue, Oct 9, 2018 at 4:59 PM Junio C Hamano <gitster@pobox.com> wrote:
> > My inclination is to recommend to:
> >
> > (1) name the "show the current one" not "--current" but with some
> > verb
> >
> > (2) display nothing when there is no current branch (i.e. detached
> > HEAD) and without any error.
>
> Sensible suggestions. Also, please documentation any new option(s) in
> Documentation/git-branch.txt.
Sorry, I was expecting to see the documentation update in patch 1 and
didn't notice that it was being done by patch 2. The reason I had that
expectation is that a change of functionality and the documentation of
that change are logically related, thus (usually) ought to be
presented together. Therefore, when you re-roll, you may want to
consider squashing the two patches into one.
next prev parent reply other threads:[~2018-10-10 9:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 18:20 [PATCH 0/2] branch: introduce --current display option Daniels Umanovskis
2018-10-09 20:59 ` Junio C Hamano
2018-10-10 9:29 ` Eric Sunshine
2018-10-10 9:42 ` Eric Sunshine [this message]
2018-10-10 14:24 ` Rafael Ascensão
2018-10-10 23:51 ` brian m. carlson
2018-10-10 15:03 ` Ævar Arnfjörð Bjarmason
2018-10-10 16:29 ` Daniels Umanovskis
2018-10-10 18:08 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cToXS+pT4Kp0uejtRkvJdSmso9a_Q=Odrhox5htzqBvTw@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=daniels@umanovskis.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).