From: Daniels Umanovskis <daniels@umanovskis.se>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] branch: introduce --current display option
Date: Wed, 10 Oct 2018 18:29:57 +0200 [thread overview]
Message-ID: <d6e8a7a4-2de1-7ffe-2848-d372cb550a2d@umanovskis.se> (raw)
In-Reply-To: <87woqpetd3.fsf@evledraar.gmail.com>
On 10/10/18 5:03 PM, Ævar Arnfjörð Bjarmason wrote:
>
> I'm mildly negative on this because git-rev-parse is plumbing, but
> git-branch is porcelain [..]
>
> We also list git-rev-parse as porcelain, just under "Porcelain / Ancillary
> Commands / Interrogators".
>
> Should we just move it to plumbing? I don't know.
From my perspective as a Git user, not developer, git-rev-parse is
between plumbing and porcelain, but much more plumbing. It's listed as
porcelain but is connected to the plumbing git-rev-list, and for the
most part it does things incomprehensible without understanding Git
internals. Then it also has a bunch of options that are very useful in
scripts but unrelated to revisions, here I mean --git-dir or
--is-inside-work-tree.
I'd be happy to submit a documentation patch for discussion that
formally moves rev-parse to plumbing.
> Also, as much as our current scripting interface can be very confusing
> (you might not think "get current branch" is under rev-parse), I can't
> help but think that adding two different ways to spew out the exact same
> thing to two different commands is heading in the wrong
> direction.
Agreed, so I'm very much inclined to move forward with Junio's preferred
solution on this, which would also act differently by only outputting
the branch when you're really on a branch, and being silent in e.g.
detached HEAD.
next prev parent reply other threads:[~2018-10-10 16:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 18:20 [PATCH 0/2] branch: introduce --current display option Daniels Umanovskis
2018-10-09 20:59 ` Junio C Hamano
2018-10-10 9:29 ` Eric Sunshine
2018-10-10 9:42 ` Eric Sunshine
2018-10-10 14:24 ` Rafael Ascensão
2018-10-10 23:51 ` brian m. carlson
2018-10-10 15:03 ` Ævar Arnfjörð Bjarmason
2018-10-10 16:29 ` Daniels Umanovskis [this message]
2018-10-10 18:08 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6e8a7a4-2de1-7ffe-2848-d372cb550a2d@umanovskis.se \
--to=daniels@umanovskis.se \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).