From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Peter Krefting <peter@softwolves.pp.se>,
git@vger.kernel.org, Jeff King <peff@peff.net>,
Christian Couder <christian.couder@gmail.com>,
Michael Osipov <michael.osipov@innomotics.com>
Subject: Re: [PATCH v3] bisect: report the found commit with "show"
Date: Mon, 15 Apr 2024 17:33:29 -0400 [thread overview]
Message-ID: <CAPig+cSY3vp6V=4SWmxyCi+7QY74eGnzPM6bu5LU5j00n8-j5g@mail.gmail.com> (raw)
In-Reply-To: <xmqq7cgyl3pr.fsf@gitster.g>
On Mon, Apr 15, 2024 at 5:24 PM Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
> >> Pass some hard-coded options to "git show" to make the output similar
> >> to the one we are replacing, such as showing a patch summary only.
> >>
> >> Signed-off-By: Peter Krefting <peter@softwolves.pp.se>
> >> ---
>
> Curious how you trimmed the trailers from the submitted patch ;-)
>
> Although we do not use Cc: in this project, we do recommend use of
> the "Reported-by" trailer in Documentation/SubmittingPatches.
Sorry if that caused any confusion. I wasn't trying to make some sort
of implicit suggestion to the patch author (such as "don't use Cc:
trailers"). Rather, to ease the reading burden for others, I
habitually trim off chunks of the email which aren't relevant to the
portions about which I'm commenting. So, although I always leave the
Signed-off-by: intact, I often trim off other trailers, sometimes even
parts of the commit message (replacing with "[...]"), and, of course,
entire chunks of the patch body.
next prev parent reply other threads:[~2024-04-15 21:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 20:14 [PATCH v3] bisect: report the found commit with "show" Peter Krefting
2024-04-14 1:28 ` Eric Sunshine
2024-04-15 21:24 ` Junio C Hamano
2024-04-15 21:33 ` Eric Sunshine [this message]
2024-04-16 5:13 ` Jeff King
2024-04-16 19:44 ` Peter Krefting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cSY3vp6V=4SWmxyCi+7QY74eGnzPM6bu5LU5j00n8-j5g@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=michael.osipov@innomotics.com \
--cc=peff@peff.net \
--cc=peter@softwolves.pp.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).