From: Peter Krefting <peter@softwolves.pp.se>
To: Eric Sunshine <sunshine@sunshineco.com>,
Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Cc: git@vger.kernel.org,
Christian Couder <christian.couder@gmail.com>,
Michael Osipov <michael.osipov@innomotics.com>
Subject: Re: [PATCH v3] bisect: report the found commit with "show"
Date: Tue, 16 Apr 2024 20:44:21 +0100 (CET) [thread overview]
Message-ID: <70e5d02e-7728-260b-40c3-a19cf68d9b0e@softwolves.pp.se> (raw)
In-Reply-To: <20240416051358.GB1745631@coredump.intra.peff.net>
Eric sunshine:
> Style nit: On this project, multi-line comments are formatted like this:
Indeed. Fixed this in v4.
Junio C Hamano:
>>> Signed-off-By: Peter Krefting <peter@softwolves.pp.se>
>>> ---
> Curious how you trimmed the trailers from the submitted patch ;-)
Yeah. I had some extra information in my local commit footer, to make
sure I remember add the correct Cc in the outgoing mail. I didn't
intend to remove the Reported-by trailer (and in v4 I see that I
forgot to trim it at all; so much for posting stuff late in the
evening, especially just after pushing a localization update).
> What is more problematic is that the message is sent with
>
> Content-Type: text/plain; format=flowed; charset=US-ASCII
>
> and the contents of the message is in that flawed format, possibly
> corrupting whitespaces in irrecoverable ways.
Right. I need to remember to disable that when posting patches. I
haven't come around to trying to get the Git built-in tools for sending
patches, as the last patch I submitted this way was in 2009, two mail
hosts ago. It oughtn't have been corrupted by that as it was just an
import of the git format-patch output file, and...
> Peter, if the resulting commit I push out later today botches some
> whitespaces due to this issue, please complain.
...it comes out just fine (as a v3.5 patch, as my v4 also changed the
command-line options, which we should not).
Eric Sunshine:
> Sorry if that caused any confusion. I wasn't trying to make some
> sort of implicit suggestion to the patch author (such as "don't use
> Cc: trailers").
It was not you, it was me trimming the posted patch a little bit too
much.
--
\\// Peter - http://www.softwolves.pp.se/
prev parent reply other threads:[~2024-04-16 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 20:14 [PATCH v3] bisect: report the found commit with "show" Peter Krefting
2024-04-14 1:28 ` Eric Sunshine
2024-04-15 21:24 ` Junio C Hamano
2024-04-15 21:33 ` Eric Sunshine
2024-04-16 5:13 ` Jeff King
2024-04-16 19:44 ` Peter Krefting [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70e5d02e-7728-260b-40c3-a19cf68d9b0e@softwolves.pp.se \
--to=peter@softwolves.pp.se \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=michael.osipov@innomotics.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).