From: Eric Sunshine <sunshine@sunshineco.com>
To: Zhang Lei <zhanglei002@gmail.com>
Cc: Duy Nguyen <pclouds@gmail.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v2] worktree: add: introduce --checkout option
Date: Thu, 24 Mar 2016 21:29:31 -0400 [thread overview]
Message-ID: <CAPig+cS2qMZyUkf9Nekp+QaVkjc1oHXb4QF3wFDnBdF3WMU3iQ@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cTtRgMz_6oEXmBN2MHG65arq51JsoBL9QeWBFNLgFnCmw@mail.gmail.com>
On Thu, Mar 24, 2016 at 9:22 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Thu, Mar 24, 2016 at 5:52 AM, Zhang Lei <zhanglei002@gmail.com> wrote:
>> 2016-03-24 17:16 GMT+08:00 Duy Nguyen <pclouds@gmail.com>:
>>> I think we can follow git-clone and use '-n' for this. [...]
>>
>> My PATCH v1 did follow git-clone -n, however, Junio C Hamano and Eric Sunshine
>> suggested that we should avoid doing so , as --no-no-checkout could be
>> confusing.
>
> My impression was that Duy was suggesting only that -n be recognized
> as shorthand for --no-checkout, however, git-worktree already
> recognizes -n as shorthand for --dry-run (as a consequence of using
> OPT__DRY_RUN), so -n as shorthand for --no-checkout is a no-go.
Ignore this. It's only 'prune' which recognizes -n, so it's possible
that 'add' could recognize it for an alternate meaning (though the
documentation would want to make this very clear).
next prev parent reply other threads:[~2016-03-25 1:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 15:08 [PATCH] add option -n (--no-checkout) to git-worktree add Ray Zhang
2016-03-23 15:49 ` Eric Sunshine
2016-03-23 15:51 ` Junio C Hamano
2016-03-23 17:43 ` Eric Sunshine
2016-03-24 6:07 ` [PATCH v2] worktree: add: introduce --checkout option Ray Zhang
2016-03-24 9:16 ` Duy Nguyen
2016-03-24 9:52 ` Zhang Lei
2016-03-25 1:22 ` Eric Sunshine
2016-03-25 1:29 ` Eric Sunshine [this message]
2016-03-25 1:49 ` Duy Nguyen
2016-03-25 11:31 ` Zhang Lei
2016-03-25 11:41 ` Duy Nguyen
2016-03-25 12:06 ` Zhang Lei
2016-03-25 12:15 ` Duy Nguyen
2016-03-25 13:02 ` Mike Rappazzo
2016-03-25 1:18 ` Eric Sunshine
2016-03-25 11:25 ` [PATCH v3] " Ray Zhang
2016-03-27 19:49 ` Eric Sunshine
2016-03-28 10:52 ` [PATCH v4] " Ray Zhang
2016-03-28 17:40 ` Junio C Hamano
2016-03-29 10:11 ` [PATCH v5] " Ray Zhang
2016-03-29 10:54 ` John Keeping
2016-03-29 18:04 ` Eric Sunshine
2016-03-29 20:15 ` John Keeping
2016-03-29 20:28 ` Junio C Hamano
2016-03-29 19:20 ` Eric Sunshine
2016-03-30 3:11 ` Zhang Lei
2016-03-30 17:59 ` Eric Sunshine
[not found] ` <CAPig+cSkE-xoaXnXHZHB4xz=ehCR973PaKbZJRyiTvHWn0AyoA@mail.gmail.com>
2016-03-29 18:43 ` [PATCH v4] " Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cS2qMZyUkf9Nekp+QaVkjc1oHXb4QF3wFDnBdF3WMU3iQ@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=zhanglei002@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).