From: Zhang Lei <zhanglei002@gmail.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v2] worktree: add: introduce --checkout option
Date: Fri, 25 Mar 2016 20:06:51 +0800 [thread overview]
Message-ID: <CABEEbiAeMZ=PSScFJ98DkqyDBGTC1OBvTb8bLAn=whLjXJvdzA@mail.gmail.com> (raw)
In-Reply-To: <CACsJy8AyMUn_AAF-DNGvjS8D+qdFLNuVBYvAjide6wA-ZnHJ5w@mail.gmail.com>
Yes, path basename makes sense.
I am asking this question because we have some legacy code requires
that working tree
called something like 'src', as a result, multiple branch would have
src1 src2 src3 under .git/worktrees
which could not be easy to maintain.
I agreed with you, we should give users such option.
2016-03-25 19:41 GMT+08:00 Duy Nguyen <pclouds@gmail.com>:
> On Fri, Mar 25, 2016 at 6:31 PM, Zhang Lei <zhanglei002@gmail.com> wrote:
>> By the way, Duy, another unrelated question: why worktree name under
>> .git/worktrees is being named
>> after the working tree path basename? I think branch name is more
>> reasonable since we don't allow checking out
>> the same branch twice.
>
> Because branch name is not always available (e.g. detached HEAD) and
> checkout branch can be switched later on. And normally you'll get
> branch name there anyway with "git worktree add something" because the
> branch "something" is automatically created. I've been wondering if
> it's worth supporting "git worktree -b abc ./" where we create
> worktree "./abc" based on branch name too.
> --
> Duy
next prev parent reply other threads:[~2016-03-25 12:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 15:08 [PATCH] add option -n (--no-checkout) to git-worktree add Ray Zhang
2016-03-23 15:49 ` Eric Sunshine
2016-03-23 15:51 ` Junio C Hamano
2016-03-23 17:43 ` Eric Sunshine
2016-03-24 6:07 ` [PATCH v2] worktree: add: introduce --checkout option Ray Zhang
2016-03-24 9:16 ` Duy Nguyen
2016-03-24 9:52 ` Zhang Lei
2016-03-25 1:22 ` Eric Sunshine
2016-03-25 1:29 ` Eric Sunshine
2016-03-25 1:49 ` Duy Nguyen
2016-03-25 11:31 ` Zhang Lei
2016-03-25 11:41 ` Duy Nguyen
2016-03-25 12:06 ` Zhang Lei [this message]
2016-03-25 12:15 ` Duy Nguyen
2016-03-25 13:02 ` Mike Rappazzo
2016-03-25 1:18 ` Eric Sunshine
2016-03-25 11:25 ` [PATCH v3] " Ray Zhang
2016-03-27 19:49 ` Eric Sunshine
2016-03-28 10:52 ` [PATCH v4] " Ray Zhang
2016-03-28 17:40 ` Junio C Hamano
2016-03-29 10:11 ` [PATCH v5] " Ray Zhang
2016-03-29 10:54 ` John Keeping
2016-03-29 18:04 ` Eric Sunshine
2016-03-29 20:15 ` John Keeping
2016-03-29 20:28 ` Junio C Hamano
2016-03-29 19:20 ` Eric Sunshine
2016-03-30 3:11 ` Zhang Lei
2016-03-30 17:59 ` Eric Sunshine
[not found] ` <CAPig+cSkE-xoaXnXHZHB4xz=ehCR973PaKbZJRyiTvHWn0AyoA@mail.gmail.com>
2016-03-29 18:43 ` [PATCH v4] " Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABEEbiAeMZ=PSScFJ98DkqyDBGTC1OBvTb8bLAn=whLjXJvdzA@mail.gmail.com' \
--to=zhanglei002@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).