git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: timschumi@gmx.de
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] doc: Don't echo sed command for manpage-base-url.xsl
Date: Tue, 28 Aug 2018 17:25:42 -0400	[thread overview]
Message-ID: <CAPig+cRnPziVKe0pxqb+QTMTZCDvWvLfQUFLU53aYuOW4Mm52A@mail.gmail.com> (raw)
In-Reply-To: <20180828212104.2515-1-timschumi@gmx.de>

On Tue, Aug 28, 2018 at 5:21 PM Tim Schumacher <timschumi@gmx.de> wrote:
> Previously, the sed command for generating manpage-base-url.xsl
> was printed to the console when being run.
>
> For the purpose of silencing it, define a $(QUIET) variable which
> contains an '@' if verbose mode isn't enabled and which is empty
> otherwise. This just silences the command invocation without doing
> anything else.

One thing that is missing from this commit message is the explanation
of _why_ this is desirable. And, why only this command? Without
understanding the underlying reason(s), it's hard to judge the value
of this change.

Thanks.

  reply	other threads:[~2018-08-28 21:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 21:21 [PATCH] doc: Don't echo sed command for manpage-base-url.xsl Tim Schumacher
2018-08-28 21:25 ` Eric Sunshine [this message]
2018-08-28 21:35 ` Junio C Hamano
2018-08-29 13:43 ` [PATCH v2] " Tim Schumacher
2018-08-29 15:47   ` [PATCH v3] " Tim Schumacher
2018-08-29 16:55     ` Jonathan Nieder
2018-08-29 17:42       ` Tim Schumacher
2018-08-29 19:19       ` Junio C Hamano
2018-08-29 16:49   ` [PATCH v2] " Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cRnPziVKe0pxqb+QTMTZCDvWvLfQUFLU53aYuOW4Mm52A@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=timschumi@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).