From: Jonathan Nieder <jrnieder@gmail.com>
To: Tim Schumacher <timschumi@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com, sunshine@sunshineco.com
Subject: Re: [PATCH v3] doc: Don't echo sed command for manpage-base-url.xsl
Date: Wed, 29 Aug 2018 09:55:40 -0700 [thread overview]
Message-ID: <20180829165540.GB170940@aiede.svl.corp.google.com> (raw)
In-Reply-To: <20180829154720.20297-1-timschumi@gmx.de>
Tim Schumacher wrote:
> Subject: doc: Don't echo sed command for manpage-base-url.xsl
Cribbing from my review of v2: a description like
Documentation/Makefile: make manpage-base-url.xsl generation quieter
would make it more obvious what this does when viewed in "git log
--oneline".
> Previously, the sed command for generating manpage-base-url.xsl
> was printed to the console when being run.
>
> Make the console output for this rule similiar to all the
> other rules by printing a short status message instead of
> the whole command.
>
> Signed-off-by: Tim Schumacher <timschumi@gmx.de>
> ---
> Documentation/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Oh! Ignore my reply to v2; looks like you anticipated what I was
going to suggest already. For next time, if you include a note about
what changed between versions after the --- delimiter, that can help
save some time.
With or without the suggested commit message tweak,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thank you.
next prev parent reply other threads:[~2018-08-29 16:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 21:21 [PATCH] doc: Don't echo sed command for manpage-base-url.xsl Tim Schumacher
2018-08-28 21:25 ` Eric Sunshine
2018-08-28 21:35 ` Junio C Hamano
2018-08-29 13:43 ` [PATCH v2] " Tim Schumacher
2018-08-29 15:47 ` [PATCH v3] " Tim Schumacher
2018-08-29 16:55 ` Jonathan Nieder [this message]
2018-08-29 17:42 ` Tim Schumacher
2018-08-29 19:19 ` Junio C Hamano
2018-08-29 16:49 ` [PATCH v2] " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829165540.GB170940@aiede.svl.corp.google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
--cc=timschumi@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).