From: Eric Sunshine <sunshine@sunshineco.com>
To: Antoine Queru <Antoine.Queru@ensimag.grenoble-inp.fr>
Cc: Git List <git@vger.kernel.org>,
William Duclot <william.duclot@ensimag.grenoble-inp.fr>,
simon rabourg <simon.rabourg@ensimag.grenoble-inp.fr>,
francois beutin <francois.beutin@ensimag.grenoble-inp.fr>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v4] upload-pack.c: use of parse-options API
Date: Fri, 27 May 2016 12:59:14 -0400 [thread overview]
Message-ID: <CAPig+cRipGvwqXQhY1koOLR2h=VcHqrTMhp_zbphYtaabQ0qAw@mail.gmail.com> (raw)
In-Reply-To: <20160527141628.1677-1-Antoine.Queru@ensimag.grenoble-inp.fr>
On Fri, May 27, 2016 at 10:16 AM, Antoine Queru
<Antoine.Queru@ensimag.grenoble-inp.fr> wrote:
> upload-pack.c: use of parse-options API
Matthieu already mentioned that this should use imperative mood:
upload-pack: use parse-options API
> Option parsing now uses the parser API instead of a local parser.
> Code is now more compact.
Imperative:
Use the parse-options API rather than a hand-rolled
option parser.
That the code becomes more compact is a nice result of this change,
but not particularly important, thus not really worth a mention in the
commit message.
> Description for --stateless-rpc and --advertise-refs come from
> the commit 42526b4 (Add stateless RPC options to upload-pack,
> receive-pack, 2009-10-30).
s/from the commit/from/
> Signed-off-by: Antoine Queru <antoine.queru@grenoble-inp.fr>
> Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
> ---
> diff --git a/Documentation/git-upload-pack.txt b/Documentation/git-upload-pack.txt
> @@ -31,6 +31,19 @@ OPTIONS
> +--stateless-rpc::
> + the programs now assume they may perform only a single read-write
s/the/The/
Also, to what "programs" does this refer? And what does "now" mean here?
> + cycle with stdin and stdout. This fits with the HTTP POST request
> + processing model where a program may read the request, write a
> + response, and must exit.
> +
> +--advertise-refs::
> + When --advertise-refs is passed as a command line parameter only
The entire "When ... parameter" bit is redundant, isn't it? Why not
just say "Perform only..."?
> + the initial ref advertisement is output, and the program exits
> + immediately. This fits with the HTTP GET request model, where
> + no request content is received but a response must be produced.
> +
> +
Style: Drop the extra blank line.
> <directory>::
> The repository to sync from.
>
> diff --git a/upload-pack.c b/upload-pack.c
> @@ -817,11 +821,21 @@ static int upload_pack_config(const char *var, const char *value, void *unused)
> -int main(int argc, char **argv)
> +int main(int argc, const char **argv)
> {
> - char *dir;
> - int i;
> + const char *dir;
> int strict = 0;
> + struct option options[] = {
> + OPT_BOOL(0, "stateless-rpc", &stateless_rpc,
> + N_("quit after a single request/response exchange")),
> + OPT_BOOL(0, "advertise-refs", &advertise_refs,
> + N_("only the initial ref advertisement is output, program exits immediately")),
Possible rewrite: "exit immediately after initial ref advertisement"
> + OPT_BOOL(0, "strict", &strict,
> + N_("do not try <directory>/.git/ if <directory> is no Git directory")),
Use of OPT_BOOL introduces a --no-strict option which didn't exist
before. Does this need to be documented? (Genuine question.)
> + OPT_INTEGER(0, "timeout", &timeout,
> + N_("interrupt transfer after <n> seconds of inactivity")),
> + OPT_END()
> + };
next prev parent reply other threads:[~2016-05-27 16:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 16:40 [PATCH] upload-pack.c: use of parse-options API Antoine Queru
2016-05-18 18:08 ` Jeff King
2016-05-19 10:10 ` Antoine Queru
2016-05-19 11:57 ` Jeff King
2016-05-19 14:36 ` Matthieu Moy
2016-05-19 15:39 ` [PATCH v2] " Antoine Queru
2016-05-19 16:10 ` Matthieu Moy
2016-05-19 16:46 ` Junio C Hamano
2016-05-20 6:55 ` Matthieu Moy
2016-05-19 16:58 ` Junio C Hamano
2016-05-20 6:53 ` Matthieu Moy
2016-05-20 16:52 ` Junio C Hamano
2016-05-23 13:02 ` [PATCH v3] " Antoine Queru
2016-05-23 18:03 ` Matthieu Moy
2016-05-27 14:16 ` [PATCH v4] " Antoine Queru
2016-05-27 14:52 ` Matthieu Moy
2016-05-27 16:59 ` Eric Sunshine [this message]
2016-05-30 14:27 ` Antoine Queru
2016-05-30 14:53 ` [PATCH v5] upload-pack.c: use " Antoine Queru
2016-05-30 15:06 ` Matthieu Moy
2016-05-30 19:26 ` Junio C Hamano
2016-05-31 9:53 ` Antoine Queru
2016-05-31 11:27 ` Matthieu Moy
2016-05-31 17:16 ` Junio C Hamano
2016-06-01 15:49 ` Antoine Queru
2016-05-31 9:57 ` [PATCH v6] " Antoine Queru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cRipGvwqXQhY1koOLR2h=VcHqrTMhp_zbphYtaabQ0qAw@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=Antoine.Queru@ensimag.grenoble-inp.fr \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=francois.beutin@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=simon.rabourg@ensimag.grenoble-inp.fr \
--cc=william.duclot@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).