git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthieu Moy <matthieu.moy@grenoble-inp.fr>,
	Antoine Queru <Antoine.Queru@ensimag.grenoble-inp.fr>,
	git@vger.kernel.org,
	william duclot <william.duclot@ensimag.grenoble-inp.fr>,
	simon rabourg <simon.rabourg@ensimag.grenoble-inp.fr>,
	francois beutin <francois.beutin@ensimag.grenoble-inp.fr>
Subject: Re: [PATCH v2] upload-pack.c: use of parse-options API
Date: Fri, 20 May 2016 08:53:10 +0200 (CEST)	[thread overview]
Message-ID: <1446970271.10941827.1463727190993.JavaMail.zimbra@imag.fr> (raw)
In-Reply-To: <xmqq60uakmr4.fsf@gitster.mtv.corp.google.com>

Junio C Hamano wrote:
> Encouraging use of "send-email" with "--patience" is a losing
> approach if your goal is to present more reviewable diff, isn't it?
> Using "send-email" as if it is a front-end of "format-patch" means
> you lose the opportunity for the final proof-reading (not just
> finding typoes in the message, but the shape of diff, like you are
> pointing out).
> 
> Using "format-patch --patience" or some other diff option, and pick
> the best one to give to "send-email" would indeed be a way to do so.

It's a matter of taste. My flow is "send-email-only", I do as much as
possible in-tree, and when I notice something to do during "git send-email",
I just abort and retry. So "Oops, looks ugly, I'll try with another
option" is OK in this flow.

> What is happening is that Antoine's patch (which is slightly
> different from what you quoted above) has trailing whitespace after
> "setup_path();"

Nice catch!

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  reply	other threads:[~2016-05-20  6:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 16:40 [PATCH] upload-pack.c: use of parse-options API Antoine Queru
2016-05-18 18:08 ` Jeff King
2016-05-19 10:10   ` Antoine Queru
2016-05-19 11:57     ` Jeff King
2016-05-19 14:36       ` Matthieu Moy
2016-05-19 15:39 ` [PATCH v2] " Antoine Queru
2016-05-19 16:10   ` Matthieu Moy
2016-05-19 16:46     ` Junio C Hamano
2016-05-20  6:55       ` Matthieu Moy
2016-05-19 16:58     ` Junio C Hamano
2016-05-20  6:53       ` Matthieu Moy [this message]
2016-05-20 16:52         ` Junio C Hamano
2016-05-23 13:02   ` [PATCH v3] " Antoine Queru
2016-05-23 18:03     ` Matthieu Moy
2016-05-27 14:16     ` [PATCH v4] " Antoine Queru
2016-05-27 14:52       ` Matthieu Moy
2016-05-27 16:59       ` Eric Sunshine
2016-05-30 14:27         ` Antoine Queru
2016-05-30 14:53       ` [PATCH v5] upload-pack.c: use " Antoine Queru
2016-05-30 15:06         ` Matthieu Moy
2016-05-30 19:26         ` Junio C Hamano
2016-05-31  9:53           ` Antoine Queru
2016-05-31 11:27           ` Matthieu Moy
2016-05-31 17:16             ` Junio C Hamano
2016-06-01 15:49               ` Antoine Queru
2016-05-31  9:57         ` [PATCH v6] " Antoine Queru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446970271.10941827.1463727190993.JavaMail.zimbra@imag.fr \
    --to=matthieu.moy@grenoble-inp.fr \
    --cc=Antoine.Queru@ensimag.grenoble-inp.fr \
    --cc=francois.beutin@ensimag.grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=simon.rabourg@ensimag.grenoble-inp.fr \
    --cc=william.duclot@ensimag.grenoble-inp.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).