From: Eric Sunshine <sunshine@sunshineco.com>
To: Jeff King <peff@peff.net>
Cc: Git List <git@vger.kernel.org>,
Baruch Burstein <bmburstein@gmail.com>,
Randall Becker <rsbecker@nexbridge.com>
Subject: Re: [RFC PATCH] vreportf: ensure sensible ordering of normal and error output
Date: Wed, 1 Dec 2021 00:38:16 -0500 [thread overview]
Message-ID: <CAPig+cRB45nwUin4Lv-j2dAQob1SSu7hGyM2c3E8G2ym_uFB2w@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cT+YfgBG3Aqszp+y7iy_megboECZy3NkMqUjBj7=Z661A@mail.gmail.com>
On Tue, Nov 30, 2021 at 9:36 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Tue, Nov 30, 2021 at 3:47 PM Jeff King <peff@peff.net> wrote:
> > On Tue, Nov 30, 2021 at 09:05:54AM -0500, Eric Sunshine wrote:
> > > (1) I don't think the practice is documented anywhere, so people --
> > > including me when I wrote builtin/worktree.c -- might not know about
> > > it. Indeed, we don't seem to be entirely consistent about doing it
> > > this way. Randomly picking submodule-helper.c, for instance, I see
> > > status-like messages going to stdout:
> >
> > Yeah, we've definitely not been consistent here. There's no silver
> > bullet for this aside from vigilance during review, but probably laying
> > out guidelines could help.
>
> Thanks for the reference. I'll take a stab at adding a blurb about
> this to CodingGuidelines.
I just posted a patch which updates CodingGuidelines to talk a bit about this:
https://lore.kernel.org/git/20211201053214.2902-1-sunshine@sunshineco.com/
next prev parent reply other threads:[~2021-12-01 5:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 4:39 [RFC PATCH] vreportf: ensure sensible ordering of normal and error output Eric Sunshine
2021-11-30 5:13 ` Junio C Hamano
2021-11-30 7:14 ` Jeff King
2021-11-30 7:23 ` Jeff King
2021-11-30 15:10 ` Ævar Arnfjörð Bjarmason
2021-11-30 20:52 ` Jeff King
2021-11-30 14:15 ` Eric Sunshine
2021-11-30 7:21 ` Jeff King
2021-11-30 14:05 ` Eric Sunshine
2021-11-30 14:57 ` Eric Sunshine
2021-12-01 13:51 ` "breaking" command output message parsing (was: [RFC PATCH] vreportf: ensure sensible ordering of normal and error output) Ævar Arnfjörð Bjarmason
2021-12-01 14:34 ` Eric Sunshine
2021-11-30 20:47 ` [RFC PATCH] vreportf: ensure sensible ordering of normal and error output Jeff King
2021-12-01 2:36 ` Eric Sunshine
2021-12-01 5:38 ` Eric Sunshine [this message]
2021-12-01 21:20 ` Ævar Arnfjörð Bjarmason
2021-12-02 0:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cRB45nwUin4Lv-j2dAQob1SSu7hGyM2c3E8G2ym_uFB2w@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=bmburstein@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).