From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 559E71F953 for ; Wed, 1 Dec 2021 05:38:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346764AbhLAFly (ORCPT ); Wed, 1 Dec 2021 00:41:54 -0500 Received: from mail-pl1-f179.google.com ([209.85.214.179]:33752 "EHLO mail-pl1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231488AbhLAFls (ORCPT ); Wed, 1 Dec 2021 00:41:48 -0500 Received: by mail-pl1-f179.google.com with SMTP id y7so16824581plp.0 for ; Tue, 30 Nov 2021 21:38:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PssoNew3A9CZ+O2u1w/obXklrsSdx95opuGYwknWpP0=; b=ini/yHI1+ISgB4HlsLsLyY5ibsXl26h8fO3Vo8zZljnM4PIxv5ux6TcxbpuMJDs4hU prCSNG/+VX3TmY+u5+aWKJd5rTWdQ48TWn/2+S24ZxPdDza6cuXJhVmWDB+aA7v/HbTy dnXEI1WrArRA7VyLv+w0UxjShHISy/eVg3RN/ZX2W6v4M04Ff7VfEjDg7reQ9Q9g9PLJ Wh3bjp3MameBkTux9cbCXZxOUa5rD0u0J4IKciaxN7Dbqz5hW03I5PViJwWDEV0nzfmn kLXi54njOe4k5agpg8e/VXbxtDVwlrikY9QCpts8x3mAyGy79RQOd6iY5cKPPn6PAY4T lV3Q== X-Gm-Message-State: AOAM533pvheQht9BToP0QL9h8Xtc78WAFfUF/CrjOB3uNkBeV22fORuo RAUWNd4CC7v1PjZI/qJUrSNCHqM2h1e5/3CrXd8= X-Google-Smtp-Source: ABdhPJxW6vWD+PGBPQrsbyd3lUVh4OGBB5bfB9kRi/AIriDxZqobsqVp3wAnVrCHianUJsPmapQbd29QwXe47xUPK9E= X-Received: by 2002:a17:90a:b107:: with SMTP id z7mr4805037pjq.104.1638337107732; Tue, 30 Nov 2021 21:38:27 -0800 (PST) MIME-Version: 1.0 References: <20211130043946.19987-1-sunshine@sunshineco.com> In-Reply-To: From: Eric Sunshine Date: Wed, 1 Dec 2021 00:38:16 -0500 Message-ID: Subject: Re: [RFC PATCH] vreportf: ensure sensible ordering of normal and error output To: Jeff King Cc: Git List , Baruch Burstein , Randall Becker Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Nov 30, 2021 at 9:36 PM Eric Sunshine wrote: > On Tue, Nov 30, 2021 at 3:47 PM Jeff King wrote: > > On Tue, Nov 30, 2021 at 09:05:54AM -0500, Eric Sunshine wrote: > > > (1) I don't think the practice is documented anywhere, so people -- > > > including me when I wrote builtin/worktree.c -- might not know about > > > it. Indeed, we don't seem to be entirely consistent about doing it > > > this way. Randomly picking submodule-helper.c, for instance, I see > > > status-like messages going to stdout: > > > > Yeah, we've definitely not been consistent here. There's no silver > > bullet for this aside from vigilance during review, but probably laying > > out guidelines could help. > > Thanks for the reference. I'll take a stab at adding a blurb about > this to CodingGuidelines. I just posted a patch which updates CodingGuidelines to talk a bit about this: https://lore.kernel.org/git/20211201053214.2902-1-sunshine@sunshineco.com/