From: Eric Sunshine <sunshine@sunshineco.com>
To: Anthony Ramine <n.oxyde@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH] wildmatch: properly fold case everywhere
Date: Thu, 30 May 2013 06:09:42 -0400 [thread overview]
Message-ID: <CAPig+cQZd4Y5gwJkf4NT73xv5hYmNQeZ_kccrzF9_12WbzONJw@mail.gmail.com> (raw)
In-Reply-To: <E670228E-B029-422C-B048-5F28E3AEB731@gmail.com>
On Thu, May 30, 2013 at 5:29 AM, Anthony Ramine <n.oxyde@gmail.com> wrote:
> Yes indeed. Will amend. Should I add your name in Reviewed-by as well?
No. I merely spotted a minor typographical error.
> --
> Anthony Ramine
>
> Le 30 mai 2013 à 11:07, Eric Sunshine a écrit :
>
>> On Thu, May 30, 2013 at 4:45 AM, Anthony Ramine <n.oxyde@gmail.com> wrote:
>>> Case folding is not done correctly when matching against the [:upper:]
>>> character class and uppercased character ranges (e.g. A-Z).
>>> Specifically, an uppercase letter fails to match against any of them
>>> when case folding is requested because plain characters in the pattern
>>> and the whole string and preemptively lowercased to handle the base case
>>
>> Did you mean s/and preemptively/are preemptively/ ?
>>
>>> fast.
>>>
>>> That optimization is kept and ISLOWER() is used in the [:upper:] case
>>> when case folding is requested, while matching against a character range
>>> is retried with toupper() if the character was lowercase, as the bounds
>>> of the range itself cannot be modified (in a case-insensitive context,
>>> [A-_] is not equivalent to [a-_]).
>>>
>>> Signed-off-by: Anthony Ramine <n.oxyde@gmail.com>
>
next prev parent reply other threads:[~2013-05-30 10:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 12:32 [PATCH] wildmatch: properly fold case everywhere Anthony Ramine
2013-05-28 12:53 ` Duy Nguyen
2013-05-28 13:01 ` Anthony Ramine
2013-05-28 13:10 ` [PATCH v2] " Anthony Ramine
2013-05-28 13:58 ` [PATCH v3] " Anthony Ramine
2013-05-29 13:22 ` Duy Nguyen
2013-05-29 13:37 ` Anthony Ramine
2013-05-29 13:52 ` Duy Nguyen
2013-05-29 17:57 ` Anthony Ramine
2013-05-30 0:04 ` Duy Nguyen
2013-05-30 8:45 ` [PATCH] " Anthony Ramine
2013-05-30 8:52 ` Duy Nguyen
2013-05-30 9:07 ` Eric Sunshine
2013-05-30 9:29 ` Anthony Ramine
2013-05-30 10:09 ` Eric Sunshine [this message]
2013-05-30 10:19 ` [PATCH v5] " Anthony Ramine
2013-06-02 21:53 ` Junio C Hamano
2013-06-02 23:42 ` Anthony Ramine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cQZd4Y5gwJkf4NT73xv5hYmNQeZ_kccrzF9_12WbzONJw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=n.oxyde@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).