From: Duy Nguyen <pclouds@gmail.com>
To: Anthony Ramine <n.oxyde@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] wildmatch: properly fold case everywhere
Date: Tue, 28 May 2013 19:53:47 +0700 [thread overview]
Message-ID: <CACsJy8Bu2XvapGHjcKZJuATqB90MXSCoNHkke9CBeiwSvzpH8A@mail.gmail.com> (raw)
In-Reply-To: <1369744361-44918-1-git-send-email-n.oxyde@gmail.com>
On Tue, May 28, 2013 at 7:32 PM, Anthony Ramine <n.oxyde@gmail.com> wrote:
> @@ -196,6 +196,11 @@ static int dowild(const uchar *p, const uchar *text, unsigned int flags)
> }
> if (t_ch <= p_ch && t_ch >= prev_ch)
> matched = 1;
> + else if ((flags & WM_CASEFOLD) && ISLOWER(t_ch)) {
> + t_ch = toupper(t_ch);
This happens in a while loop where t_ch may be used again. Should we
make a local copy of toupper(t_ch) and leave t_ch untouched?
> + if (t_ch <= p_ch && t_ch >= prev_ch)
> + matched = 1;
> + }
> p_ch = 0; /* This makes "prev_ch" get set to 0. */
> } else if (p_ch == '[' && p[1] == ':') {
> const uchar *s;
--
Duy
next prev parent reply other threads:[~2013-05-28 12:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 12:32 [PATCH] wildmatch: properly fold case everywhere Anthony Ramine
2013-05-28 12:53 ` Duy Nguyen [this message]
2013-05-28 13:01 ` Anthony Ramine
2013-05-28 13:10 ` [PATCH v2] " Anthony Ramine
2013-05-28 13:58 ` [PATCH v3] " Anthony Ramine
2013-05-29 13:22 ` Duy Nguyen
2013-05-29 13:37 ` Anthony Ramine
2013-05-29 13:52 ` Duy Nguyen
2013-05-29 17:57 ` Anthony Ramine
2013-05-30 0:04 ` Duy Nguyen
2013-05-30 8:45 ` [PATCH] " Anthony Ramine
2013-05-30 8:52 ` Duy Nguyen
2013-05-30 9:07 ` Eric Sunshine
2013-05-30 9:29 ` Anthony Ramine
2013-05-30 10:09 ` Eric Sunshine
2013-05-30 10:19 ` [PATCH v5] " Anthony Ramine
2013-06-02 21:53 ` Junio C Hamano
2013-06-02 23:42 ` Anthony Ramine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8Bu2XvapGHjcKZJuATqB90MXSCoNHkke9CBeiwSvzpH8A@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=n.oxyde@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).