From: Eric Sunshine <sunshine@sunshineco.com>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/6] Documentation/config: mention "now" and "never" for 'expire' settings
Date: Tue, 28 Jul 2015 16:33:06 -0400 [thread overview]
Message-ID: <CAPig+cQPj3wA8EfdNTskCUc__QXLwR07Ck4QrYvc9wnZqOxtug@mail.gmail.com> (raw)
In-Reply-To: <55B58C3B.7040200@alum.mit.edu>
On Sun, Jul 26, 2015 at 9:41 PM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> On 07/23/2015 09:00 PM, Eric Sunshine wrote:
>> In addition to approxidate-style values ("2.months.ago", "yesterday"),
>> consumers of 'gc.*expire*' configuration variables also accept and
>> respect 'now'/'all' ("do it immediately") and 'never'/'false' ("suppress
>> entirely").
>>
>> Suggested-by: Michael Haggerty <mhagger@alum.mit.edu>
>> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
>> ---
>> gc.pruneExpire::
>> When 'git gc' is run, it will call 'prune --expire 2.weeks.ago'.
>> Override the grace period with this config variable. The value
>> - "now" may be used to disable this grace period and always prune
>> - unreachable objects immediately.
>> + "now" may be used to disable this grace period and always prune
>> + unreachable objects immediately; or "never" to suppress pruning.
>
> A semicolon should be used without a conjunction, and the parts of a
> sentence joined by a semicolon should be independent clauses. So this
> should probably be
>
> [...] The value
> "now" may be used to disable this grace period and always prune
> unreachable objects immediately, or "never" may be used to
> suppress pruning.
I was absent from school that day...
>> @@ -1328,7 +1330,8 @@ gc.reflogExpireUnreachable::
>> gc.<ref>.reflogExpireUnreachable::
>> 'git reflog expire' removes reflog entries older than
>> this time and are not reachable from the current tip;
>> - defaults to 30 days. With "<pattern>" (e.g. "refs/stash")
>> + defaults to 30 days. The value "all" expires all entries; and
>> + "false" disables expiration. With "<pattern>" (e.g. "refs/stash")
>> in the middle, the setting applies only to the refs that
>> match the <pattern>.
>
> Also, I wonder why you suggest "now"/"never" for the first two settings,
> but "all"/"false" for the second two. Wouldn't it be less confusing to
> be consistent?
It was intentional due to the way I worded the sentence. It sounded
slightly strange to my ear to say:
The value "now" expires all entries; and "never"
disables expiration.
whereas:
The value "all" expires all entries; ...
sounded nice. But, upon reflection, with a slight re-wording[1], "all"
and "never" work, as well.
[1]: http://article.gmane.org/gmane.comp.version-control.git/274828
next prev parent reply other threads:[~2015-07-28 20:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 4:00 [PATCH 0/6] minor documentation improvements Eric Sunshine
2015-07-24 4:00 ` [PATCH 1/6] Documentation/git-worktree: fix broken 'linkgit' invocation Eric Sunshine
2015-07-24 4:00 ` [PATCH 2/6] Documentation/config: mention "now" and "never" for 'expire' settings Eric Sunshine
2015-07-27 1:41 ` Michael Haggerty
2015-07-28 17:33 ` Eric Sunshine
2015-07-28 18:36 ` Junio C Hamano
2015-07-28 20:33 ` Eric Sunshine [this message]
2015-07-24 4:00 ` [PATCH 3/6] Documentation/git: drop outdated Cogito reference Eric Sunshine
2015-07-24 4:00 ` [PATCH 4/6] Documentation/git-tools: improve discoverability of Git wiki Eric Sunshine
2015-07-24 4:00 ` [PATCH 5/6] Documentation/git-tools: fix item text formatting Eric Sunshine
2015-07-24 4:00 ` [PATCH 6/6] Documentation/git-tools: drop references to defunct tools Eric Sunshine
2015-07-24 18:03 ` Junio C Hamano
2015-07-24 21:34 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cQPj3wA8EfdNTskCUc__QXLwR07Ck4QrYvc9wnZqOxtug@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).