From: Michael Haggerty <mhagger@alum.mit.edu>
To: Eric Sunshine <sunshine@sunshineco.com>, git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/6] Documentation/config: mention "now" and "never" for 'expire' settings
Date: Sun, 26 Jul 2015 18:41:15 -0700 [thread overview]
Message-ID: <55B58C3B.7040200@alum.mit.edu> (raw)
In-Reply-To: <1437710457-38592-3-git-send-email-sunshine@sunshineco.com>
On 07/23/2015 09:00 PM, Eric Sunshine wrote:
> In addition to approxidate-style values ("2.months.ago", "yesterday"),
> consumers of 'gc.*expire*' configuration variables also accept and
> respect 'now'/'all' ("do it immediately") and 'never'/'false' ("suppress
> entirely").
>
> Suggested-by: Michael Haggerty <mhagger@alum.mit.edu>
> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
> ---
>
> Reference: http://article.gmane.org/gmane.comp.version-control.git/274325
>
> I sneaked in a minor whitespace fix.
>
> Documentation/config.txt | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 1a8a399..cc920c0 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -1307,20 +1307,22 @@ gc.packRefs::
> gc.pruneExpire::
> When 'git gc' is run, it will call 'prune --expire 2.weeks.ago'.
> Override the grace period with this config variable. The value
> - "now" may be used to disable this grace period and always prune
> - unreachable objects immediately.
> + "now" may be used to disable this grace period and always prune
> + unreachable objects immediately; or "never" to suppress pruning.
A semicolon should be used without a conjunction, and the parts of a
sentence joined by a semicolon should be independent clauses. So this
should probably be
[...] The value
"now" may be used to disable this grace period and always prune
unreachable objects immediately, or "never" may be used to
suppress pruning.
> gc.worktreePruneExpire::
> When 'git gc' is run, it calls
> 'git worktree prune --expire 3.months.ago'.
> This config variable can be used to set a different grace
> period. The value "now" may be used to disable the grace
> - period and prune $GIT_DIR/worktrees immediately.
> + period and prune $GIT_DIR/worktrees immediately; or "never" to
> + suppress pruning.
The same here.
> gc.reflogExpire::
> gc.<pattern>.reflogExpire::
> 'git reflog expire' removes reflog entries older than
> - this time; defaults to 90 days. With "<pattern>" (e.g.
> + this time; defaults to 90 days. The value "all" expires all
> + entries; and "false" disables expiration. With "<pattern>" (e.g.
> "refs/stash") in the middle the setting applies only to
> the refs that match the <pattern>.
Similarly, this could be fixed to
[...] The value "all" expires all
entries; "false" disables expiration. [...]
> @@ -1328,7 +1330,8 @@ gc.reflogExpireUnreachable::
> gc.<ref>.reflogExpireUnreachable::
> 'git reflog expire' removes reflog entries older than
> this time and are not reachable from the current tip;
> - defaults to 30 days. With "<pattern>" (e.g. "refs/stash")
> + defaults to 30 days. The value "all" expires all entries; and
> + "false" disables expiration. With "<pattern>" (e.g. "refs/stash")
> in the middle, the setting applies only to the refs that
> match the <pattern>.
The same here.
Also, I wonder why you suggest "now"/"never" for the first two settings,
but "all"/"false" for the second two. Wouldn't it be less confusing to
be consistent?
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
next prev parent reply other threads:[~2015-07-27 1:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 4:00 [PATCH 0/6] minor documentation improvements Eric Sunshine
2015-07-24 4:00 ` [PATCH 1/6] Documentation/git-worktree: fix broken 'linkgit' invocation Eric Sunshine
2015-07-24 4:00 ` [PATCH 2/6] Documentation/config: mention "now" and "never" for 'expire' settings Eric Sunshine
2015-07-27 1:41 ` Michael Haggerty [this message]
2015-07-28 17:33 ` Eric Sunshine
2015-07-28 18:36 ` Junio C Hamano
2015-07-28 20:33 ` Eric Sunshine
2015-07-24 4:00 ` [PATCH 3/6] Documentation/git: drop outdated Cogito reference Eric Sunshine
2015-07-24 4:00 ` [PATCH 4/6] Documentation/git-tools: improve discoverability of Git wiki Eric Sunshine
2015-07-24 4:00 ` [PATCH 5/6] Documentation/git-tools: fix item text formatting Eric Sunshine
2015-07-24 4:00 ` [PATCH 6/6] Documentation/git-tools: drop references to defunct tools Eric Sunshine
2015-07-24 18:03 ` Junio C Hamano
2015-07-24 21:34 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B58C3B.7040200@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).