From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git List" <git@vger.kernel.org>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Eugen Konkov" <kes-kes@yandex.ru>
Subject: Re: [PATCH] format-patch: clarify --creation-factor=<factor>
Date: Fri, 29 Jul 2022 20:25:26 -0400 [thread overview]
Message-ID: <CAPig+cQ94oC-6wftkP_=RSEsOVPKeuBWuMshDkwV+Xu_FjrKeg@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cTxM2vr11XRU-zrNAJRwveP0W9d0x8Euvr6HKmQicKgPQ@mail.gmail.com>
On Thu, Jul 28, 2022 at 5:09 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Thu, Jul 28, 2022 at 4:59 PM Junio C Hamano <gitster@pobox.com> wrote:
> > >> - [--range-diff=<previous> [--creation-factor=<percent>]]
> > >> + [--range-diff=<previous> [--creation-factor=<factor>]]
> >
> > Eric, I am not sure if the other patch for the range-diff command as
> > a standalone patch is worth it. Perhaps you can help me by
> > submitting a single combined patch to cover the above as well as
> > what we wrote in the two patches, with you marked as the primary
> > author and with Helped-by: that credits Ævar?
>
> Will do.
Given Dscho's response in [1] which states that "percent" is more
accurate than "factor", perhaps these two patches are unwanted after
all, and instead the documentation of "creation factor" in
Documentation/git-range-diff.txt ought to be expanded with a better
explanation, as hinted in [2].
[1]: https://lore.kernel.org/git/85snn12q-po05-osqs-n1o0-n6040392q01q@tzk.qr/
[2]: https://lore.kernel.org/git/xmqq5yjf4l60.fsf@gitster.g/
next prev parent reply other threads:[~2022-07-30 0:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 12:54 --creation-factor=100 does not show code Eugen Konkov
2022-07-28 14:59 ` Johannes Schindelin
2022-07-28 16:52 ` Re* " Junio C Hamano
2022-07-28 17:12 ` Ævar Arnfjörð Bjarmason
2022-07-28 17:44 ` Junio C Hamano
2022-07-28 19:46 ` Ævar Arnfjörð Bjarmason
2022-07-28 19:54 ` Junio C Hamano
2022-07-28 17:49 ` [PATCH] format-patch: clarify --creation-factor=<factor> Eric Sunshine
2022-07-28 20:55 ` Ævar Arnfjörð Bjarmason
2022-07-28 20:59 ` Junio C Hamano
2022-07-28 21:09 ` Eric Sunshine
2022-07-30 0:25 ` Eric Sunshine [this message]
2022-07-31 18:56 ` Junio C Hamano
2022-07-29 13:16 ` Re* --creation-factor=100 does not show code Johannes Schindelin
2022-07-29 22:19 ` Junio C Hamano
2022-08-01 23:17 ` Junio C Hamano
2023-04-02 21:55 ` Eugen Konkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cQ94oC-6wftkP_=RSEsOVPKeuBWuMshDkwV+Xu_FjrKeg@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kes-kes@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).