From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Eugen Konkov <kes-kes@yandex.ru>
Subject: Re: [PATCH] format-patch: clarify --creation-factor=<factor>
Date: Thu, 28 Jul 2022 22:55:31 +0200 [thread overview]
Message-ID: <220728.867d3xj6s0.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <20220728174953.66964-1-sunshine@sunshineco.com>
On Thu, Jul 28 2022, Eric Sunshine wrote:
> The value is not a percentage that ranges from 0 to 100, so stop
> referring to it as `percent`; instead follow the lead of the `git
> range-diff` documentation and call it `factor`.
>
> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
> ---
>
> This is a sibling to Junio's patch[1].
>
> [1]: https://lore.kernel.org/git/xmqqo7x9ch7n.fsf_-_@gitster.g/
>
> Documentation/git-format-patch.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt
> index be797d7a28..e06475abcd 100644
> --- a/Documentation/git-format-patch.txt
> +++ b/Documentation/git-format-patch.txt
> @@ -27,7 +27,7 @@ SYNOPSIS
> [--[no-]encode-email-headers]
> [--no-notes | --notes[=<ref>]]
> [--interdiff=<previous>]
> - [--range-diff=<previous> [--creation-factor=<percent>]]
> + [--range-diff=<previous> [--creation-factor=<factor>]]
> [--filename-max-length=<n>]
> [--progress]
> [<common diff options>]
> @@ -321,7 +321,7 @@ product of `format-patch` is generated, and they are not passed to
> the underlying `range-diff` machinery used to generate the cover-letter
> material (this may change in the future).
>
> ---creation-factor=<percent>::
> +--creation-factor=<factor>::
> Used with `--range-diff`, tweak the heuristic which matches up commits
> between the previous and current series of patches by adjusting the
> creation/deletion cost fudge factor. See linkgit:git-range-diff[1])
Looks good as far as it goes, looks like both of your patches need to
also tweak this bit though:
$ git -P grep 'percentage.*creation' -- '*.c'
builtin/log.c: N_("percentage by which creation is weighted")),
builtin/range-diff.c: N_("percentage by which creation is weighted")),
Probably just s/percentage/factor/ in for those -h strings?
next prev parent reply other threads:[~2022-07-28 20:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 12:54 --creation-factor=100 does not show code Eugen Konkov
2022-07-28 14:59 ` Johannes Schindelin
2022-07-28 16:52 ` Re* " Junio C Hamano
2022-07-28 17:12 ` Ævar Arnfjörð Bjarmason
2022-07-28 17:44 ` Junio C Hamano
2022-07-28 19:46 ` Ævar Arnfjörð Bjarmason
2022-07-28 19:54 ` Junio C Hamano
2022-07-28 17:49 ` [PATCH] format-patch: clarify --creation-factor=<factor> Eric Sunshine
2022-07-28 20:55 ` Ævar Arnfjörð Bjarmason [this message]
2022-07-28 20:59 ` Junio C Hamano
2022-07-28 21:09 ` Eric Sunshine
2022-07-30 0:25 ` Eric Sunshine
2022-07-31 18:56 ` Junio C Hamano
2022-07-29 13:16 ` Re* --creation-factor=100 does not show code Johannes Schindelin
2022-07-29 22:19 ` Junio C Hamano
2022-08-01 23:17 ` Junio C Hamano
2023-04-02 21:55 ` Eugen Konkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220728.867d3xj6s0.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kes-kes@yandex.ru \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).