git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "郑文辉(Techlive Zheng)" <techlivezheng@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "David A. Greene" <greened@obbligato.org>, git@vger.kernel.org
Subject: Re: [PATCH 1/8] Use %B for Split Subject/Body
Date: Mon, 7 Jan 2013 23:18:02 +0800	[thread overview]
Message-ID: <CAPYzjrT_8g26y-QrYvbQYoySWskGdn15jCX60rz04wQFQ2ikVw@mail.gmail.com> (raw)
In-Reply-To: <7vtxr1bg4g.fsf@alter.siamese.dyndns.org>

2013/1/1 Junio C Hamano <gitster@pobox.com>:
> "David A. Greene" <greened@obbligato.org> writes:
>
>> From: Techlive Zheng <techlivezheng@gmail.com>
>>
>> Use %B to format the commit message and body to avoid an extra newline
>> if a commit only has a subject line.
>
> Is this an unconditional improvement, or is it generally an
> improvement but for some users it may be a regression?  I am
> guessing it is the former but am just making sure.

This patch will make sure the commits in the result branch by using
`git-subtree split` stays intact as they were in the original branch.

This patch will break the current existing branch that splitted before
this patch, becuase these branches were splitted with the wrongly
altered commit messages.

Maybe a fallback option should be added to make sure these branches
could still be updated.

Though, this patch defintely should be merged, becuase no one expects
his commit message be altered durging the splitting process.

  parent reply	other threads:[~2013-01-07 15:27 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-01  3:57 git-subtree Patches to Apply David A. Greene
2013-01-01  3:57 ` [PATCH 1/8] Use %B for Split Subject/Body David A. Greene
2013-01-01  4:06   ` greened
2013-01-01  5:58     ` Junio C Hamano
2013-01-01 22:25       ` greened
2013-01-01  5:56   ` Junio C Hamano
2013-01-01 22:24     ` greened
     [not found]     ` <CAPYzjrTqmzuWoDg+zvLxwB7g6J4J2wbBqpL+UbHKRHcbjA4HrA@mail.gmail.com>
2013-01-07 15:00       ` 郑文辉(Techlive Zheng)
2013-01-07 15:18     ` 郑文辉(Techlive Zheng) [this message]
2013-01-07 16:53       ` Junio C Hamano
2013-01-01 21:25   ` Junio C Hamano
2013-01-01 22:29     ` greened
2013-01-02  0:30       ` Junio C Hamano
2013-01-08 10:40         ` greened
2013-01-01  3:57 ` [PATCH 2/8] Add --unannotate David A. Greene
2013-01-01 21:30   ` Junio C Hamano
2013-01-01 22:31     ` greened
2013-01-02  0:32       ` Junio C Hamano
2013-01-08 10:42         ` greened
2013-01-17 21:07       ` James Nylen
2013-01-22  8:44         ` greened
2013-01-22 16:04           ` Junio C Hamano
2013-01-01  3:57 ` [PATCH 3/8] Better Error Handling for add David A. Greene
2013-01-01 21:39   ` Junio C Hamano
2013-01-01 22:33     ` greened
2013-01-02  2:21       ` Junio C Hamano
2013-01-01  3:57 ` [PATCH 4/8] Fix Synopsis David A. Greene
2013-01-01 21:40   ` Junio C Hamano
2013-01-01 22:35     ` greened
2013-01-01  3:57 ` [PATCH 5/8] Honor DESTDIR David A. Greene
2013-01-01 21:42   ` Junio C Hamano
2013-01-01 22:36     ` greened
2013-01-01  3:57 ` [PATCH 6/8] Make the Manual Directory if Needed David A. Greene
2013-01-01 21:44   ` Junio C Hamano
2013-01-01 22:37     ` greened
2013-01-01  3:57 ` [PATCH 7/8] Ignore git-subtree David A. Greene
2013-01-01 21:44   ` Junio C Hamano
2013-01-01  3:57 ` [PATCH 8/8] Fix Documentation Typo David A. Greene

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPYzjrT_8g26y-QrYvbQYoySWskGdn15jCX60rz04wQFQ2ikVw@mail.gmail.com \
    --to=techlivezheng@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=greened@obbligato.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).