Re: [PATCH 1/8] Use %B for Split Subject/Body

git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed

From: Junio C Hamano <gitster@pobox.com>
To: "David A. Greene" <greened@obbligato.org>
Cc: git@vger.kernel.org, Techlive Zheng <techlivezheng@gmail.com>
Subject: Re: [PATCH 1/8] Use %B for Split Subject/Body
Date: Mon, 31 Dec 2012 21:56:47 -0800	[thread overview]
Message-ID: <7vtxr1bg4g.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1357012655-24974-2-git-send-email-greened@obbligato.org> (David A. Greene's message of "Mon, 31 Dec 2012 21:57:28 -0600")

"David A. Greene" <greened@obbligato.org> writes:

> From: Techlive Zheng <techlivezheng@gmail.com>
>
> Use %B to format the commit message and body to avoid an extra newline
> if a commit only has a subject line.

Is this an unconditional improvement, or is it generally an
improvement but for some users it may be a regression?  I am
guessing it is the former but am just making sure.

> Author:    Techlive Zheng <techlivezheng@gmail.com>
>
> Signed-off-by: David A. Greene <greened@obbligato.org>

Please don't do "Author: " which does not add anything new.  That is
what "From: " is for.  Instead it needs to be a sign-off.

Also, is that a real name, I have to wonder?

Thanks.

next prev parent reply	other threads:[~2013-01-01  5:57 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-01  3:57 git-subtree Patches to Apply David A. Greene
2013-01-01  3:57 ` [PATCH 1/8] Use %B for Split Subject/Body David A. Greene
2013-01-01  4:06   ` greened
2013-01-01  5:58     ` Junio C Hamano
2013-01-01 22:25       ` greened
2013-01-01  5:56   ` Junio C Hamano [this message]
2013-01-01 22:24     ` greened
     [not found]     ` <CAPYzjrTqmzuWoDg+zvLxwB7g6J4J2wbBqpL+UbHKRHcbjA4HrA@mail.gmail.com>
2013-01-07 15:00       ` 郑文辉(Techlive Zheng)
2013-01-07 15:18     ` 郑文辉(Techlive Zheng)
2013-01-07 16:53       ` Junio C Hamano
2013-01-01 21:25   ` Junio C Hamano
2013-01-01 22:29     ` greened
2013-01-02  0:30       ` Junio C Hamano
2013-01-08 10:40         ` greened
2013-01-01  3:57 ` [PATCH 2/8] Add --unannotate David A. Greene
2013-01-01 21:30   ` Junio C Hamano
2013-01-01 22:31     ` greened
2013-01-02  0:32       ` Junio C Hamano
2013-01-08 10:42         ` greened
2013-01-17 21:07       ` James Nylen
2013-01-22  8:44         ` greened
2013-01-22 16:04           ` Junio C Hamano
2013-01-01  3:57 ` [PATCH 3/8] Better Error Handling for add David A. Greene
2013-01-01 21:39   ` Junio C Hamano
2013-01-01 22:33     ` greened
2013-01-02  2:21       ` Junio C Hamano
2013-01-01  3:57 ` [PATCH 4/8] Fix Synopsis David A. Greene
2013-01-01 21:40   ` Junio C Hamano
2013-01-01 22:35     ` greened
2013-01-01  3:57 ` [PATCH 5/8] Honor DESTDIR David A. Greene
2013-01-01 21:42   ` Junio C Hamano
2013-01-01 22:36     ` greened
2013-01-01  3:57 ` [PATCH 6/8] Make the Manual Directory if Needed David A. Greene
2013-01-01 21:44   ` Junio C Hamano
2013-01-01 22:37     ` greened
2013-01-01  3:57 ` [PATCH 7/8] Ignore git-subtree David A. Greene
2013-01-01 21:44   ` Junio C Hamano
2013-01-01  3:57 ` [PATCH 8/8] Fix Documentation Typo David A. Greene

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vtxr1bg4g.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=greened@obbligato.org \
    --cc=techlivezheng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).