From: "Mantas Mikulėnas" <grawity@gmail.com>
To: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] credential-libsecret: unlock locked secrets
Date: Mon, 6 Nov 2017 11:53:42 +0200 [thread overview]
Message-ID: <CAPWNY8WUo8n903AcUPQ-EsfmtjoKRJDGXp0Wy4KoBSbrOhrR0A@mail.gmail.com> (raw)
In-Reply-To: <20171103204449.5268-1-dennis@kaarsemaker.net>
On Fri, Nov 3, 2017 at 10:44 PM, Dennis Kaarsemaker
<dennis@kaarsemaker.net> wrote:
> Credentials exposed by the secret service DBUS interface may be locked.
> Setting the SECRET_SEARCH_UNLOCK flag will make the secret service
> unlock these secrets, possibly prompting the user for credentials to do
> so. Without this flag, the secret is simply not loaded.
>
> Signed-off-by: Dennis Kaarsemaker <dennis@kaarsemaker.net>
> ---
> contrib/credential/libsecret/git-credential-libsecret.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/credential/libsecret/git-credential-libsecret.c b/contrib/credential/libsecret/git-credential-libsecret.c
> index 4c56979d8a..b4750c9ee8 100644
> --- a/contrib/credential/libsecret/git-credential-libsecret.c
> +++ b/contrib/credential/libsecret/git-credential-libsecret.c
> @@ -104,7 +104,7 @@ static int keyring_get(struct credential *c)
> items = secret_service_search_sync(service,
> SECRET_SCHEMA_COMPAT_NETWORK,
> attributes,
> - SECRET_SEARCH_LOAD_SECRETS,
> + SECRET_SEARCH_LOAD_SECRETS | SECRET_SEARCH_UNLOCK,
> NULL,
> &error);
> g_hash_table_unref(attributes);
> --
> 2.15.0-rc2-464-gb5de734
>
Looks okay. (It seems that's what all other programs do, too...)
--
Mantas Mikulėnas <grawity@gmail.com>
prev parent reply other threads:[~2017-11-06 9:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 16:00 Git libsecret No Unlock Dialog Issue Yaroslav Sapozhnyk
2017-11-02 18:35 ` Stefan Beller
2017-11-02 18:50 ` Yaroslav Sapozhnyk
2017-11-02 18:55 ` Dennis Kaarsemaker
2017-11-02 19:48 ` Yaroslav Sapozhnyk
2017-11-03 18:01 ` Yaroslav Sapozhnyk
2017-11-03 20:44 ` [PATCH] credential-libsecret: unlock locked secrets Dennis Kaarsemaker
2017-11-06 9:53 ` Mantas Mikulėnas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPWNY8WUo8n903AcUPQ-EsfmtjoKRJDGXp0Wy4KoBSbrOhrR0A@mail.gmail.com \
--to=grawity@gmail.com \
--cc=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).