From: Yaroslav Sapozhnyk <yaroslav.sapozhnik@gmail.com>
To: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Cc: Stefan Beller <sbeller@google.com>, git <git@vger.kernel.org>
Subject: Re: Git libsecret No Unlock Dialog Issue
Date: Fri, 3 Nov 2017 14:01:38 -0400 [thread overview]
Message-ID: <CAOAxMp9fi3n=anfE_XCqDMtsr89pPANgCK1SL-RnOkwYjOM8hQ@mail.gmail.com> (raw)
In-Reply-To: <CAOAxMp9H6M+t5RvYiem+kXrY920ZDYvyyYt4GZ7ZnkpXVA_c0g@mail.gmail.com>
What version should include this fix? Cannot find a pr for it.
Thanks for providing the fix!
Regards,
Yaroslav
On Thu, Nov 2, 2017 at 3:48 PM, Yaroslav Sapozhnyk
<yaroslav.sapozhnik@gmail.com> wrote:
> I've tested the code change locally and seems like it fixes the issue.
>
> Yaroslav
>
> On Thu, Nov 2, 2017 at 2:55 PM, Dennis Kaarsemaker
> <dennis@kaarsemaker.net> wrote:
>> On Thu, 2017-11-02 at 11:35 -0700, Stefan Beller wrote:
>>> On Thu, Nov 2, 2017 at 9:00 AM, Yaroslav Sapozhnyk
>>> <yaroslav.sapozhnik@gmail.com> wrote:
>>> > When using Git on Fedora with locked password store
>>> > credential-libsecret asks for username/password instead of displaying
>>> > the unlock dialog.
>>>
>>> Git as packaged by Fedora or upstream Git (which version)?
>>
>> Looking at the code: current upstream git. Looking at the documentation
>> for libsecret, this should fix it. I've not been able to test it
>> though.
>>
>> diff --git a/contrib/credential/libsecret/git-credential-libsecret.c b/contrib/credential/libsecret/git-credential-libsecret.c
>> index 4c56979d8a..b4750c9ee8 100644
>> --- a/contrib/credential/libsecret/git-credential-libsecret.c
>> +++ b/contrib/credential/libsecret/git-credential-libsecret.c
>> @@ -104,7 +104,7 @@ static int keyring_get(struct credential *c)
>> items = secret_service_search_sync(service,
>> SECRET_SCHEMA_COMPAT_NETWORK,
>> attributes,
>> - SECRET_SEARCH_LOAD_SECRETS,
>> + SECRET_SEARCH_LOAD_SECRETS | SECRET_SEARCH_UNLOCK,
>> NULL,
>> &error);
>> g_hash_table_unref(attributes);
>
>
>
> --
> Regards,
> Yaroslav Sapozhnyk
--
Regards,
Yaroslav Sapozhnyk
next prev parent reply other threads:[~2017-11-03 18:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 16:00 Git libsecret No Unlock Dialog Issue Yaroslav Sapozhnyk
2017-11-02 18:35 ` Stefan Beller
2017-11-02 18:50 ` Yaroslav Sapozhnyk
2017-11-02 18:55 ` Dennis Kaarsemaker
2017-11-02 19:48 ` Yaroslav Sapozhnyk
2017-11-03 18:01 ` Yaroslav Sapozhnyk [this message]
2017-11-03 20:44 ` [PATCH] credential-libsecret: unlock locked secrets Dennis Kaarsemaker
2017-11-06 9:53 ` Mantas Mikulėnas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOAxMp9fi3n=anfE_XCqDMtsr89pPANgCK1SL-RnOkwYjOM8hQ@mail.gmail.com' \
--to=yaroslav.sapozhnik@gmail.com \
--cc=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).