From: Carlo Arenas <carenas@gmail.com>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH] Use mingw.h declarations for gmtime_r/localtime_r on msys2
Date: Thu, 18 Nov 2021 21:38:00 -0800 [thread overview]
Message-ID: <CAPUEspjZmwoOWSJHBrykOfNEv=zLi2nQLs1EkUPTPr-nSNf08Q@mail.gmail.com> (raw)
In-Reply-To: <20211118090542.rcaggue6zpd7r3ht@glandium.org>
On Thu, Nov 18, 2021 at 1:05 AM Mike Hommey <mh@glandium.org> wrote:
> Oh my bad, I overlooked an important part of the build log: it was a
> mingw32 build, not minwg64. Mingw64 builds fine without
> -D_POSIX_THREAD_SAFE_FUNCTIONS=200112L. Mingw32 requires it (because
> the ifdefs are for mingw64)
Can you confirm the version of the winpthread library in your SDK? and
output of your headers, or something that could back up that statement
of "ifdefs are for mingw64"?.
I definitely can't reproduce it, but I also have a freshly installed
32-bit SDK.
The proposed change was meant to be backward compatible though, which
is why I am holding on submitting it to git.git and even advocating
throwing it away (even if it has been in use for several months) and
replacing it with your original proposal, but would be good to
understand why it fails, and why yours wouldn't.
Carlo
next prev parent reply other threads:[~2021-11-19 5:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 6:39 [PATCH] Use mingw.h declarations for gmtime_r/localtime_r on msys2 Mike Hommey
2021-10-05 7:12 ` Carlo Arenas
2021-10-05 8:35 ` Mike Hommey
2021-11-18 3:02 ` Mike Hommey
2021-11-18 4:51 ` Carlo Arenas
2021-11-18 5:34 ` Mike Hommey
2021-11-18 7:58 ` Carlo Arenas
2021-11-18 9:05 ` Mike Hommey
2021-11-19 5:38 ` Carlo Arenas [this message]
2021-11-19 7:23 ` Mike Hommey
2021-11-19 9:36 ` Carlo Arenas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPUEspjZmwoOWSJHBrykOfNEv=zLi2nQLs1EkUPTPr-nSNf08Q@mail.gmail.com' \
--to=carenas@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).