From: Mike Hommey <mh@glandium.org>
To: Carlo Arenas <carenas@gmail.com>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH] Use mingw.h declarations for gmtime_r/localtime_r on msys2
Date: Tue, 5 Oct 2021 17:35:00 +0900 [thread overview]
Message-ID: <20211005083500.jd7byba4abupdub5@glandium.org> (raw)
In-Reply-To: <CAPUEspgLwLxavP3bC9OEJQTphoemQ+jxv+9Nkcvbf51uaBEpww@mail.gmail.com>
On Tue, Oct 05, 2021 at 12:12:12AM -0700, Carlo Arenas wrote:
> On Mon, Oct 4, 2021 at 11:57 PM Mike Hommey <mh@glandium.org> wrote:
> > A possible alternative fix would be to e.g. add `#define _POSIX_C_SOURCE
> > 200112L` to git-compat-util.h and add `ifndef __MINGW64_VERSION_MAJOR`
> > around the definitions of `gmtime_r` and `localtime_r` in
> > compat/mingw.c, since, after all, they are available there.
>
> something like that was merged to "main"[1] a few months ago, would
> that work for you?
This seems very close to what I was suggesting, so I would guess so :)
I'm wondering if there's a reason not to set _POSIX_C_SOURCE everywhere,
along the other _*_SOURCE's.
Mike
next prev parent reply other threads:[~2021-10-05 8:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 6:39 [PATCH] Use mingw.h declarations for gmtime_r/localtime_r on msys2 Mike Hommey
2021-10-05 7:12 ` Carlo Arenas
2021-10-05 8:35 ` Mike Hommey [this message]
2021-11-18 3:02 ` Mike Hommey
2021-11-18 4:51 ` Carlo Arenas
2021-11-18 5:34 ` Mike Hommey
2021-11-18 7:58 ` Carlo Arenas
2021-11-18 9:05 ` Mike Hommey
2021-11-19 5:38 ` Carlo Arenas
2021-11-19 7:23 ` Mike Hommey
2021-11-19 9:36 ` Carlo Arenas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005083500.jd7byba4abupdub5@glandium.org \
--to=mh@glandium.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).