From: Christian Couder <christian.couder@gmail.com>
To: hsed@unimetic.com
Cc: Jeff King <peff@peff.net>, git <git@vger.kernel.org>
Subject: Re: [PATCH V2] config: add --expiry-date
Date: Tue, 14 Nov 2017 07:21:45 +0100 [thread overview]
Message-ID: <CAP8UFD3TbmZ3bRwg-fRoSJWAFaa=UDxVsZphn_3Nt4wMz1N2=A@mail.gmail.com> (raw)
In-Reply-To: <1510625073-8842-1-git-send-email-hsed@unimetic.com>
On Tue, Nov 14, 2017 at 3:04 AM, <hsed@unimetic.com> wrote:
> From: Haaris <hsed@unimetic.com>
>
> Description:
> This patch adds a new option to the config command.
>
> Uses flag --expiry-date as a data-type to covert date-strings to
> timestamps when reading from config files (GET).
> This flag is ignored on write (SET) because the date-string is stored in
> config without performing any normalization.
>
> Creates a few test cases and documentation since its a new feature.
>
> Motivation:
> A parse_expiry_date() function already existed for api calls,
> this patch simply allows the function to be used from the command line.
>
> Signed-off-by: Haaris <hsed@unimetic.com>
Documentation/SubmittingPatches contains the following:
"Also notice that a real name is used in the Signed-off-by: line. Please
don't hide your real name."
And there is the following example before that:
Signed-off-by: Random J Developer <random@developer.example.org>
So it looks like "a real name" actually means "a real firstname and a
real surname".
It would be nice if your "Signed-off-by:" could match this format.
Also if you have a "From:" line at the beginning of the patch, please
make sure that the name there is tha same as on the "Signed-off-by:".
Thanks for working on this,
Christian.
next prev parent reply other threads:[~2017-11-14 6:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 12:19 [PATCH] config: added --expiry-date type support Haaris
2017-11-12 13:55 ` Kevin Daudt
2017-11-12 14:22 ` Jeff King
2017-11-12 14:55 ` Jeff King
[not found] ` <a05a8e8020ec31cfd9a0271ce2a00034@unimetic.com>
2017-11-12 19:43 ` hsed
2017-11-14 2:04 ` [PATCH V2] config: add --expiry-date hsed
2017-11-14 6:21 ` Christian Couder [this message]
2017-11-14 16:03 ` Marc Branchaud
2017-11-14 6:38 ` Junio C Hamano
2017-11-15 22:10 ` hsed
2017-11-16 0:05 ` [PATCH V3] " hsed
2017-11-16 0:54 ` Junio C Hamano
2017-11-17 18:15 ` hsed
2017-11-18 2:27 ` [PATCH V4] " hsed
2017-11-18 3:37 ` Junio C Hamano
2017-11-20 14:53 ` hsed
2017-11-20 17:04 ` Jeff King
2017-11-20 20:28 ` Stefan Beller
2017-11-20 20:37 ` Jeff King
2017-11-30 11:18 ` Heiko Voigt
2017-11-30 17:45 ` Jeff King
[not found] <f9d6d1cfcad17c93a0131cf69c3d7705@unimetic.com>
2017-11-13 17:53 ` [PATCH V2] " hsed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD3TbmZ3bRwg-fRoSJWAFaa=UDxVsZphn_3Nt4wMz1N2=A@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=hsed@unimetic.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).