From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>,
hsed@unimetic.com, git@vger.kernel.org,
Heiko Voigt <hvoigt@hvoigt.net>
Subject: Re: [PATCH V4] config: add --expiry-date
Date: Mon, 20 Nov 2017 12:04:43 -0500 [thread overview]
Message-ID: <20171120170443.awpvcuubsi5o6zmp@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq8tf4qmu8.fsf@gitster.mtv.corp.google.com>
On Sat, Nov 18, 2017 at 12:37:03PM +0900, Junio C Hamano wrote:
> > +int git_config_expiry_date(timestamp_t *timestamp, const char *var, const char *value)
> > +{
> > + if (!value)
> > + return config_error_nonbool(var);
> > + if (parse_expiry_date(value, timestamp))
> > + return error(_("'%s' for '%s' is not a valid timestamp"),
> > + value, var);
> > + return 0;
> > +}
> > +
>
> I think this is more correct even within the context of this
> function than dying, which suggests the need for a slightly related
> (which is not within the scope of this change) clean-up within this
> file as a #leftoverbits task. I think dying in these value parsers
> goes against the point of having die_on_error bit in the
> config-source structure; Heiko and Peff CC'ed for b2dc0945 ("do not
> die when error in config parsing of buf occurs", 2013-07-12).
Yes, I agree that ideally the value parsers should avoid dying.
Unfortunately I think it will involve some heavy refactoring, since
git_config_bool(), for instance, does not even have a spot in its
interface to return an error.
Of course we can leave those other helpers in place and add a "gently"
form for each. It is really only submodule-config.c that wants to be
careful in its callback, so we could just port that. Skimming it over,
it looks like there are a few git_config_bool() and straight-up die()
calls that could be more forgiving.
+cc Stefan, who added the die(). It may be that we don't care that much
these days about recovering from broken .gitmodules files.
> Thanks; will queue.
Thanks for reviewing. This was from the hackathon last weekend, but I
missed the later re-rolls amidst my return travel.
(And thank you, Haaris, for seeing it through!)
-Peff
next prev parent reply other threads:[~2017-11-20 17:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 12:19 [PATCH] config: added --expiry-date type support Haaris
2017-11-12 13:55 ` Kevin Daudt
2017-11-12 14:22 ` Jeff King
2017-11-12 14:55 ` Jeff King
[not found] ` <a05a8e8020ec31cfd9a0271ce2a00034@unimetic.com>
2017-11-12 19:43 ` hsed
2017-11-14 2:04 ` [PATCH V2] config: add --expiry-date hsed
2017-11-14 6:21 ` Christian Couder
2017-11-14 16:03 ` Marc Branchaud
2017-11-14 6:38 ` Junio C Hamano
2017-11-15 22:10 ` hsed
2017-11-16 0:05 ` [PATCH V3] " hsed
2017-11-16 0:54 ` Junio C Hamano
2017-11-17 18:15 ` hsed
2017-11-18 2:27 ` [PATCH V4] " hsed
2017-11-18 3:37 ` Junio C Hamano
2017-11-20 14:53 ` hsed
2017-11-20 17:04 ` Jeff King [this message]
2017-11-20 20:28 ` Stefan Beller
2017-11-20 20:37 ` Jeff King
2017-11-30 11:18 ` Heiko Voigt
2017-11-30 17:45 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120170443.awpvcuubsi5o6zmp@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hsed@unimetic.com \
--cc=hvoigt@hvoigt.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).