[PATCH] promisor-remote.h: fix an 'hdr-check' warning

[PATCH] promisor-remote.h: fix an 'hdr-check' warning

[Ramsay Jones]

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Christian,

If you need to re-roll your 'cc/multi-promisor' branch, could you
please squash this into the relevant patch (commit e52d417b57
("promisor-remote: implement promisor_remote_get_direct()", 2019-04-01)).

[I had a deja-vu moment writing this - it seems I sent a very
similar mail about 3 weeks ago. ;-) ]

Thanks!

ATB,
Ramsay Jones

 promisor-remote.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/promisor-remote.h b/promisor-remote.h
index e29cf507ab..562c7ad8a4 100644
--- a/promisor-remote.h
+++ b/promisor-remote.h
@@ -1,6 +1,8 @@
 #ifndef PROMISOR_REMOTE_H
 #define PROMISOR_REMOTE_H
 
+struct object_id;
+
 /*
  * Promisor remote linked list
  *
-- 
2.21.0

Re: [PATCH] promisor-remote.h: fix an 'hdr-check' warning

[Christian Couder]

Hi Ramsay,

On Thu, Apr 4, 2019 at 8:59 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

> If you need to re-roll your 'cc/multi-promisor' branch, could you
> please squash this into the relevant patch (commit e52d417b57
> ("promisor-remote: implement promisor_remote_get_direct()", 2019-04-01)).
>
> [I had a deja-vu moment writing this - it seems I sent a very
> similar mail about 3 weeks ago. ;-) ]

Yeah, sorry. I don't know why but I failed to notice your previous
email about this.

I have integrated the change you suggest in my patch series so it
should be in the next version.

Thanks again,
Christian.

Re: [PATCH] promisor-remote.h: fix an 'hdr-check' warning

[Junio C Hamano]

Christian Couder <christian.couder@gmail.com> writes:

> Hi Ramsay,
>
> On Thu, Apr 4, 2019 at 8:59 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
>
>> If you need to re-roll your 'cc/multi-promisor' branch, could you
>> please squash this into the relevant patch (commit e52d417b57
>> ("promisor-remote: implement promisor_remote_get_direct()", 2019-04-01)).
>>
>> [I had a deja-vu moment writing this - it seems I sent a very
>> similar mail about 3 weeks ago. ;-) ]
>
> Yeah, sorry. I don't know why but I failed to notice your previous
> email about this.
>
> I have integrated the change you suggest in my patch series so it
> should be in the next version.
>
> Thanks again,
> Christian.

Thanks, both.

[PATCH] promisor-remote.h: fix an 'hdr-check' warning

[Ramsay Jones]

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Christian,

If you need to re-roll your 'cc/multi-promisor' branch, could you please
squash this into the relevant patch (commit 9e27beaa23, "promisor-remote:
implement promisor_remote_get_direct()", 2019-06-25).

[No, this is not the same as the April patch! :-D ]

Thanks!

ATB,
Ramsay Jones

 promisor-remote.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/promisor-remote.h b/promisor-remote.h
index 8200dfc940..a9a9c77b7c 100644
--- a/promisor-remote.h
+++ b/promisor-remote.h
@@ -2,6 +2,7 @@
 #define PROMISOR_REMOTE_H
 
 struct object_id;
+struct repository;
 
 /*
  * Promisor remote linked list
-- 
2.22.0

Re: [PATCH] promisor-remote.h: fix an 'hdr-check' warning

[Christian Couder]

Hi Ramsay,

On Thu, Jun 27, 2019 at 12:14 AM Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
>
> If you need to re-roll your 'cc/multi-promisor' branch, could you please
> squash this into the relevant patch (commit 9e27beaa23, "promisor-remote:
> implement promisor_remote_get_direct()", 2019-06-25).

Sure, I have integrated it into my current development branch.

> [No, this is not the same as the April patch! :-D ]

Glad to hear that :-D

Thanks,
Christian.