From: Christian Couder <christian.couder@gmail.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Emily Shaffer <emilyshaffer@google.com>
Cc: git <git@vger.kernel.org>, Jonathan Nieder <jrnieder@gmail.com>,
Jonathan Tan <jonathantanmy@google.com>,
Josh Steadmon <steadmon@google.com>,
Glen Choo <chooglen@google.com>,
calvinwan@google.com, workflows@vger.kernel.org,
Eric Wong <e@80x24.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: Review process improvements
Date: Mon, 20 Dec 2021 11:48:24 +0100 [thread overview]
Message-ID: <CAP8UFD1M7LM630iHXb3EhgiRSoHgKzixTHmKYTA5OU1fEo69DA@mail.gmail.com> (raw)
In-Reply-To: <20211217183942.npvkb3ajnx6p5cbp@meerkat.local>
On Fri, Dec 17, 2021 at 11:00 PM Konstantin Ryabitsev
<konstantin@linuxfoundation.org> wrote:
>
> On Thu, Dec 16, 2021 at 02:46:21PM -0800, Emily Shaffer wrote:
> > Some of those discussions resulted in changes - for example,
> > GitGitGadget was improved and added to git/git, and we enjoy easy,
> > non-noisy CI runs via GitHub Actions. But some things we thought were a
> > good idea never went into practice. In the next few months, the Google
> > Git team is planning to implement some of the following changes,
Thanks for trying to make it easier and more efficient to contribute!
> > and
> > we'd appreciate your thoughts ahead of time as well as your review later
> > on:
>
> I'd like to also mention that I'm hoping to add a few more features to b4 that
> will hopefully improve the patch submission process for folks.
Thanks also for implementing and maintaining tools and sites that help
contributing!
I have added a new "Process related tools and sites" section to
https://git.github.io/Hacking-Git/ with links to GitGitGadget,
lore.kernel.org/git, public-inbox, lore+lei, b4 and git-series. I am
willing to add other tools and sites if someone knows others worth
mentioning.
[...]
> > 1. Draft a MAINTAINERS file
>
> So, I *don't* recommend that you go this route. The biggest problem with the
> MAINTAINERS file as used by the Linux development community is that making
> changes to it is a very high-latency process. It will be less of a problem for
> the much smaller git developer community, but it will still result in folks
> operating from a stale copy of the file for weeks after it is updated
> upstream.
My opinion is that a MAINTAINERS file makes more sense when there are
different mailing lists to send patches to, and trusted
lieutenants/maintainers. I am not sure that we are at that point yet.
About documentation, if some good documentation exists elsewhere, it
might be good enough to just point to it from an existing doc and/or
https://git.github.io/Hacking-Git/. Otherwise adding a new separate
doc might be better than growing an existing doc too much, which could
scare new comers.
next prev parent reply other threads:[~2021-12-20 10:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 22:46 Review process improvements Emily Shaffer
2021-12-16 23:22 ` rsbecker
2021-12-17 0:05 ` Junio C Hamano
2021-12-17 18:39 ` Konstantin Ryabitsev
2021-12-20 10:48 ` Christian Couder [this message]
2021-12-20 12:29 ` Mark Brown
2021-12-22 3:26 ` Ævar Arnfjörð Bjarmason
2021-12-22 13:07 ` Fabian Stelzer
2021-12-22 15:45 ` Konstantin Ryabitsev
2021-12-22 19:42 ` Junio C Hamano
2021-12-22 21:32 ` Konstantin Ryabitsev
2022-01-10 13:03 ` Why GitGitGadget does not use Sender:, was " Johannes Schindelin
2022-01-10 17:13 ` Junio C Hamano
2021-12-23 13:50 ` Stefan Hajnoczi
2021-12-20 11:22 ` Ævar Arnfjörð Bjarmason
2021-12-20 17:14 ` Eric Sunshine
2021-12-20 21:27 ` João Victor Bonfim
2022-01-05 1:02 ` Emily Shaffer
2022-01-09 3:26 ` João Victor Bonfim
2021-12-21 1:47 ` brian m. carlson
2022-01-05 0:45 ` Emily Shaffer
2022-01-09 8:26 ` Matthias Aßhauer
-- strict thread matches above, loose matches on Subject: below --
2021-12-20 3:35 João Victor Bonfim
2021-12-20 3:47 ` João Victor Bonfim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD1M7LM630iHXb3EhgiRSoHgKzixTHmKYTA5OU1fEo69DA@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=calvinwan@google.com \
--cc=chooglen@google.com \
--cc=e@80x24.org \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=josh@joshtriplett.org \
--cc=jrnieder@gmail.com \
--cc=konstantin@linuxfoundation.org \
--cc=steadmon@google.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).