From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Emily Shaffer" <emilyshaffer@google.com>,
git@vger.kernel.org, jrnieder@gmail.com,
jonathantanmy@google.com, steadmon@google.com,
chooglen@google.com, calvinwan@google.com,
workflows@vger.kernel.org
Subject: Re: Review process improvements
Date: Wed, 22 Dec 2021 16:32:47 -0500 [thread overview]
Message-ID: <20211222213247.5dnj3zlj53lh6l32@meerkat.local> (raw)
In-Reply-To: <xmqqh7b0juk5.fsf@gitster.g>
On Wed, Dec 22, 2021 at 11:42:02AM -0800, Junio C Hamano wrote:
> > This would require pretending that we're authorized to send mail from the
> > domain name of the commit author, so this unfortunately won't work (and hence
> > the reason why GGG does it this way). E.g. say you have:
> >
> > From: foo@redhat.com
> > Subject: [PATCH] Fix foo
>
> Would it help to use "Sender:"? When GGG or any other automation
> are trying to send e-mail on behalf of the person shown on "From:",
> I thought that it is the mechanism for them to use to identify
> themselves.
Indeed, that's how the DKIM standard wanted to deal with this problem, however
when the DMARC RFC was being drafted, this approach was deemed insufficient.
They have a good explanation for it -- there is no standard among UI clients
to handle the Sender/From discrepancy. Most MUAs will happily ignore the
Sender: field and will only show what is in From:, so this approach was
considered ineffective against phishing attacks. An attacker could easily
register a domain, set DKIM records, and then use any From: they wanted as
long as they used a valid Sender: header, knowing that it would be ignored by
most mail clients.
So, DMARC deliberately ignores the Sender: header and *only* pays attention to
the From: field for its purpose.
-K
next prev parent reply other threads:[~2021-12-22 21:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 22:46 Review process improvements Emily Shaffer
2021-12-16 23:22 ` rsbecker
2021-12-17 0:05 ` Junio C Hamano
2021-12-17 18:39 ` Konstantin Ryabitsev
2021-12-20 10:48 ` Christian Couder
2021-12-20 12:29 ` Mark Brown
2021-12-22 3:26 ` Ævar Arnfjörð Bjarmason
2021-12-22 13:07 ` Fabian Stelzer
2021-12-22 15:45 ` Konstantin Ryabitsev
2021-12-22 19:42 ` Junio C Hamano
2021-12-22 21:32 ` Konstantin Ryabitsev [this message]
2022-01-10 13:03 ` Why GitGitGadget does not use Sender:, was " Johannes Schindelin
2022-01-10 17:13 ` Junio C Hamano
2021-12-23 13:50 ` Stefan Hajnoczi
2021-12-20 11:22 ` Ævar Arnfjörð Bjarmason
2021-12-20 17:14 ` Eric Sunshine
2021-12-20 21:27 ` João Victor Bonfim
2022-01-05 1:02 ` Emily Shaffer
2022-01-09 3:26 ` João Victor Bonfim
2021-12-21 1:47 ` brian m. carlson
2022-01-05 0:45 ` Emily Shaffer
2022-01-09 8:26 ` Matthias Aßhauer
-- strict thread matches above, loose matches on Subject: below --
2021-12-20 3:35 João Victor Bonfim
2021-12-20 3:47 ` João Victor Bonfim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211222213247.5dnj3zlj53lh6l32@meerkat.local \
--to=konstantin@linuxfoundation.org \
--cc=avarab@gmail.com \
--cc=calvinwan@google.com \
--cc=chooglen@google.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=steadmon@google.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).