From: Christian Couder <christian.couder@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: "Stefan Beller" <sbeller@google.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Karsten Blees" <karsten.blees@gmail.com>,
"Nguyen Thai Ngoc Duy" <pclouds@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Johannes Sixt" <j6t@kdbg.org>, "René Scharfe" <l.s.r@web.de>,
"Stefan Naewe" <stefan.naewe@atlas-elektronik.com>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH v13 10/14] apply: change error_routine when silent
Date: Sun, 4 Sep 2016 18:45:53 +0200 [thread overview]
Message-ID: <CAP8UFD1Dssiw9=ME-084nXWd56X30vt1yEPYgyUnUjPsNcOVOw@mail.gmail.com> (raw)
In-Reply-To: <e39d9b83-949b-075c-07f6-60118dc24961@ramsayjones.plus.com>
On Sun, Sep 4, 2016 at 6:31 PM, Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
>
>
> On 04/09/16 11:54, Christian Couder wrote:
>> On Thu, Sep 1, 2016 at 10:19 AM, Christian Couder
>> <christian.couder@gmail.com> wrote:
>>> On Thu, Sep 1, 2016 at 12:20 AM, Stefan Beller <sbeller@google.com> wrote:
>>>>>
>>>>> +static void mute_routine(const char *bla, va_list params)
>>>>
>>>> Instead of 'bla' you could go with 'format' as the man page for
>>>> [f]printf puts it.
>>>> Or you could leave it empty, i.e.
>>>>
>>>> static void mute_routine(const char *, va_list)
>>>> ...
>>>
>>> Ok to do that.
>>
>> Actually I get the following error when doing that:
>>
>> apply.c: In function ‘mute_routine’:
>> apply.c:115:1: error: parameter name omitted
>> static void mute_routine(const char *, va_list)
>> ^
>> apply.c:115:1: error: parameter name omitted
>> make: *** [apply.o] Error 1
>
> Yes, this is not C++. ;-)
>
>> So I will leave it as is.
>
> I think I would prefer to see:
>
> static void mute_routine(const char *msg, va_list params)
>
> given that it would either be an error-msg or a warning-msg.
Ok for "msg".
next prev parent reply other threads:[~2016-09-04 16:45 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 18:45 [PATCH v13 00/14] libify apply and use lib in am, part 3 Christian Couder
2016-08-27 18:45 ` [PATCH v13 01/14] builtin/apply: rename option parsing functions Christian Couder
2016-08-27 18:45 ` [PATCH v13 02/14] apply: rename and move opt constants to apply.h Christian Couder
2016-08-31 21:46 ` Stefan Beller
2016-09-01 8:03 ` Christian Couder
2016-08-27 18:45 ` [PATCH v13 04/14] apply: make some parsing functions static again Christian Couder
2016-08-31 21:58 ` Stefan Beller
2016-08-27 18:45 ` [PATCH v13 05/14] apply: use error_errno() where possible Christian Couder
2016-08-31 21:59 ` Stefan Beller
2016-08-27 18:45 ` [PATCH v13 06/14] apply: make it possible to silently apply Christian Couder
2016-08-31 22:07 ` Stefan Beller
2016-09-01 8:01 ` Christian Couder
2016-09-01 16:57 ` Stefan Beller
2016-08-27 18:45 ` [PATCH v13 07/14] apply: don't print on stdout in verbosity_silent mode Christian Couder
2016-08-27 18:45 ` [PATCH v13 08/14] usage: add set_warn_routine() Christian Couder
2016-08-27 18:45 ` [PATCH v13 09/14] usage: add get_error_routine() and get_warn_routine() Christian Couder
2016-08-27 18:45 ` [PATCH v13 10/14] apply: change error_routine when silent Christian Couder
2016-08-31 22:20 ` Stefan Beller
2016-09-01 8:19 ` Christian Couder
2016-09-04 10:54 ` Christian Couder
2016-09-04 16:31 ` Ramsay Jones
2016-09-04 16:45 ` Christian Couder [this message]
2016-08-27 18:45 ` [PATCH v13 11/14] apply: refactor `git apply` option parsing Christian Couder
2016-08-27 18:45 ` [PATCH v13 12/14] apply: pass apply state to build_fake_ancestor() Christian Couder
2016-08-27 18:45 ` [PATCH v13 13/14] apply: learn to use a different index file Christian Couder
2016-08-27 18:45 ` [PATCH v13 14/14] builtin/am: use apply API in run_apply() Christian Couder
2016-08-31 22:33 ` Stefan Beller
2016-09-01 7:41 ` Christian Couder
2016-08-27 18:49 ` [PATCH v13 00/14] libify apply and use lib in am, part 3 Christian Couder
2016-08-29 19:04 ` Junio C Hamano
2016-08-29 19:52 ` Junio C Hamano
2016-08-30 10:19 ` Christian Couder
2016-08-31 22:15 ` Junio C Hamano
2016-09-01 8:28 ` Christian Couder
2016-09-01 17:48 ` Junio C Hamano
2016-09-04 20:17 ` Christian Couder
[not found] ` <20160827184547.4365-4-chriscool@tuxfamily.org>
2016-08-31 21:57 ` [PATCH v13 03/14] Move libified code from builtin/apply.c to apply.{c,h} Stefan Beller
2016-09-01 7:46 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP8UFD1Dssiw9=ME-084nXWd56X30vt1yEPYgyUnUjPsNcOVOw@mail.gmail.com' \
--to=christian.couder@gmail.com \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=karsten.blees@gmail.com \
--cc=l.s.r@web.de \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
--cc=sbeller@google.com \
--cc=stefan.naewe@atlas-elektronik.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).