From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 19B6C1F859 for ; Sun, 4 Sep 2016 16:45:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753889AbcIDQp5 (ORCPT ); Sun, 4 Sep 2016 12:45:57 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:36519 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753583AbcIDQp4 (ORCPT ); Sun, 4 Sep 2016 12:45:56 -0400 Received: by mail-wm0-f45.google.com with SMTP id c133so92642588wmd.1 for ; Sun, 04 Sep 2016 09:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kXhAIx/69THeXTizM4p3SqLs/ID5IET7psKb7+Jh+LQ=; b=N8jUBbtRdJyUjwBUBU949wxZMjivt96RuxTQ+UfYseCSklGarl0khA0NQ383+ZyRkp Mg5XgD5VccKW+SDh6ftdVFfnN8tCQgXQcmiPqFNQVxV68IbMkwm9YghL4NCTd0ltv24P y0hMXOSL7qvFReexUHZseYIrUU09s435lTRt7+zEkf5fsWV6vT+69XTqQRIMoAoBXqTb scPxnC613XQ7hLd98XlB4WZgTo19FVJghWtMhFxhEhu1ECE8d5+RHTAA2SNTm5oSwOlG Dv7kHX2EnmcsflgseCcU9RV06W7aaxYqeeO/0qiKUk30tQQpD8RwdSS4JEDdV2cKWdB3 Zijw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kXhAIx/69THeXTizM4p3SqLs/ID5IET7psKb7+Jh+LQ=; b=j29OHKa/0Ke+Gr4i4CmDvjQjrjnTPYaLr4w0AKY0YhLcehX+kpqPlmGJBLma9Gd9Se HaSE/HxjiSlEsF+cmh4AqCk3DdPMjV/1BOZJ6bqSQ+GWqKAAq/2cO4o6Zpsw8gXeQA/1 h5LSeaIjuYV/nOfjDobPxEYQIOV8NxTpiWvLSvoYSxseRhaC552zib4Bc9mJLxMyJgq7 Rx5CXYdY0T1q4hLmF4wzMftChFHhyuGbUBt1vxPTlalGCS13+SrN2rJs6aQSPDmgSMBP yFp5eXeEql7hIfRifJAV0R5n8EqCtXB5UWQFmjKrrU7LztJn6C5MxrmuxA+RjsOnCvi2 xxIA== X-Gm-Message-State: AE9vXwMWi8AKdTE7EM2pfospaZG8fAEBBjEzX99IK3OX1aD9FdnrlT14K4IAnXuFNoJ3sBoipx1w7rDBuGGsEw== X-Received: by 10.28.175.79 with SMTP id y76mr12106972wme.98.1473007554527; Sun, 04 Sep 2016 09:45:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.222.132 with HTTP; Sun, 4 Sep 2016 09:45:53 -0700 (PDT) In-Reply-To: References: <20160827184547.4365-1-chriscool@tuxfamily.org> <20160827184547.4365-11-chriscool@tuxfamily.org> From: Christian Couder Date: Sun, 4 Sep 2016 18:45:53 +0200 Message-ID: Subject: Re: [PATCH v13 10/14] apply: change error_routine when silent To: Ramsay Jones Cc: Stefan Beller , "git@vger.kernel.org" , Junio C Hamano , Jeff King , =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= , Karsten Blees , Nguyen Thai Ngoc Duy , Eric Sunshine , Johannes Sixt , =?UTF-8?Q?Ren=C3=A9_Scharfe?= , Stefan Naewe , Christian Couder Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sun, Sep 4, 2016 at 6:31 PM, Ramsay Jones wrote: > > > On 04/09/16 11:54, Christian Couder wrote: >> On Thu, Sep 1, 2016 at 10:19 AM, Christian Couder >> wrote: >>> On Thu, Sep 1, 2016 at 12:20 AM, Stefan Beller wro= te: >>>>> >>>>> +static void mute_routine(const char *bla, va_list params) >>>> >>>> Instead of 'bla' you could go with 'format' as the man page for >>>> [f]printf puts it. >>>> Or you could leave it empty, i.e. >>>> >>>> static void mute_routine(const char *, va_list) >>>> ... >>> >>> Ok to do that. >> >> Actually I get the following error when doing that: >> >> apply.c: In function =E2=80=98mute_routine=E2=80=99: >> apply.c:115:1: error: parameter name omitted >> static void mute_routine(const char *, va_list) >> ^ >> apply.c:115:1: error: parameter name omitted >> make: *** [apply.o] Error 1 > > Yes, this is not C++. ;-) > >> So I will leave it as is. > > I think I would prefer to see: > > static void mute_routine(const char *msg, va_list params) > > given that it would either be an error-msg or a warning-msg. Ok for "msg".