git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Christian Couder <christian.couder@gmail.com>
To: Andreas Schwab <schwab@suse.de>
Cc: git <git@vger.kernel.org>
Subject: Re: git replace --graft does error checking too late
Date: Wed, 27 Mar 2019 14:21:23 +0100	[thread overview]
Message-ID: <CAP8UFD111-zqa7Fhr1KnmWYAKpBN4ofqn0AvD_nP3s_WBFzLqw@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD1qU_kJ97MdLFwzx+g3F6Q+fQ9LWOBxd=1m4vSi-fxF=Q@mail.gmail.com>

On Wed, Mar 27, 2019 at 2:11 PM Christian Couder
<christian.couder@gmail.com> wrote:
>
> On Wed, Mar 27, 2019 at 11:24 AM Andreas Schwab <schwab@suse.de> wrote:
> >
> > When running `git replace --graft A B' where B is a non-commit (eg. a
> > tag) it displays an error,
>
> Yeah, it seems that when A is a commit and B a tag I get:
>
> "error: object A is a tag, not a commit"
>
> which is wrong as A is a commit.

Actually I get the above only if A is a commit but there is a tag
pointing to it. If there is no tag pointing to it I get:

error: object C is a tag, not a commit

where C is the hash of the tag object B (C=$(git rev-parse B))

So yeah, this is weird.

  reply	other threads:[~2019-03-27 13:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27 10:22 git replace --graft does error checking too late Andreas Schwab
2019-03-27 13:11 ` Christian Couder
2019-03-27 13:21   ` Christian Couder [this message]
2019-03-28  7:35     ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP8UFD111-zqa7Fhr1KnmWYAKpBN4ofqn0AvD_nP3s_WBFzLqw@mail.gmail.com \
    --to=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).