From: Andreas Schwab <schwab@suse.de>
To: git@vger.kernel.org
Subject: git replace --graft does error checking too late
Date: Wed, 27 Mar 2019 11:22:40 +0100 [thread overview]
Message-ID: <mvmd0mcsjkf.fsf@suse.de> (raw)
When running `git replace --graft A B' where B is a non-commit (eg. a
tag) it displays an error, but creates the replace ref anyway. I think
it should verify that B names a commit object before creating the ref.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next reply other threads:[~2019-03-27 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 10:22 Andreas Schwab [this message]
2019-03-27 13:11 ` git replace --graft does error checking too late Christian Couder
2019-03-27 13:21 ` Christian Couder
2019-03-28 7:35 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmd0mcsjkf.fsf@suse.de \
--to=schwab@suse.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).