From: Christian Couder <christian.couder@gmail.com>
To: Joel Teichroeb <joel@teichroeb.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/4] stash: convert apply to builtin
Date: Sun, 25 Mar 2018 21:58:59 +0200 [thread overview]
Message-ID: <CAP8UFD04LF68LONP3hxpjc4oQokSab4HYvTkazeBq8STzN6E-A@mail.gmail.com> (raw)
In-Reply-To: <CA+CzEk9QpmHK_TSBwQfEedNqrcVSBp3xY7bdv1YA_KxePiFeXw@mail.gmail.com>
On Sun, Mar 25, 2018 at 6:51 PM, Joel Teichroeb <joel@teichroeb.net> wrote:
> On Sun, Mar 25, 2018 at 1:09 AM, Christian Couder
> <christian.couder@gmail.com> wrote:
>> It seems to me that the apply_stash() shell function is also used in
>> pop_stash() and in apply_to_branch(). Can the new helper be used there
>> too instead of apply_stash()? And then could apply_stash() be remove?
>
> I wasn't really sure if I should remove code from the .sh file as it
> seems in the past the old .sh files have been kept around as examples.
Yeah, some original shell scripts that have been converted are kept in
contrib/examples/, but the shell code has still been removed from the
.sh files when they were being converted.
> Has that been done for previous conversions?
I don't think there were some cases when the shell code was not
removed. I haven't looked at all the conversions in details though.
next prev parent reply other threads:[~2018-03-25 19:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 17:37 [PATCH 0/4] Convert some stash functionality to a builtin Joel Teichroeb
2018-03-24 17:37 ` [PATCH 1/4] stash: convert apply to builtin Joel Teichroeb
2018-03-24 18:19 ` Christian Couder
2018-03-25 6:40 ` Eric Sunshine
2018-03-25 9:27 ` Christian Couder
2018-03-25 8:09 ` Christian Couder
2018-03-25 16:51 ` Joel Teichroeb
2018-03-25 19:58 ` Christian Couder [this message]
[not found] ` <20180325204653.1470-1-avarab@gmail.com>
2018-03-25 20:57 ` [PATCH] Remove contrib/examples/* Ævar Arnfjörð Bjarmason
2018-03-26 6:01 ` Jeff King
2018-03-26 20:58 ` Junio C Hamano
2018-03-25 16:43 ` [PATCH 1/4] stash: convert apply to builtin Thomas Gummerer
2018-03-28 3:30 ` Joel Teichroeb
2018-03-25 17:23 ` Thomas Gummerer
2018-03-24 17:37 ` [PATCH 2/4] stash: convert branch " Joel Teichroeb
2018-03-25 6:44 ` Eric Sunshine
2018-03-25 8:22 ` Christian Couder
2018-03-25 17:02 ` Thomas Gummerer
2018-03-24 17:37 ` [PATCH 3/4] stash: convert drop and clear " Joel Teichroeb
2018-03-24 18:22 ` Christian Couder
2018-03-25 6:49 ` Eric Sunshine
2018-03-24 17:37 ` [PATCH 4/4] stash: convert pop " Joel Teichroeb
2018-03-25 6:51 ` Eric Sunshine
2018-03-25 17:36 ` Thomas Gummerer
2018-03-25 17:39 ` [PATCH 0/4] Convert some stash functionality to a builtin Thomas Gummerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP8UFD04LF68LONP3hxpjc4oQokSab4HYvTkazeBq8STzN6E-A@mail.gmail.com \
--to=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=joel@teichroeb.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).