From: Joel Teichroeb <joel@teichroeb.net>
To: Git Mailing List <git@vger.kernel.org>,
Thomas Gummerer <t.gummerer@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Joel Teichroeb <joel@teichroeb.net>
Subject: [PATCH 3/4] stash: convert drop and clear to builtin
Date: Sat, 24 Mar 2018 10:37:06 -0700 [thread overview]
Message-ID: <20180324173707.17699-4-joel@teichroeb.net> (raw)
In-Reply-To: <20180324173707.17699-1-joel@teichroeb.net>
---
builtin/stash--helper.c | 93 +++++++++++++++++++++++++++++++++++++++++++++++++
git-stash.sh | 4 +--
2 files changed, 95 insertions(+), 2 deletions(-)
diff --git a/builtin/stash--helper.c b/builtin/stash--helper.c
index 18c4aba665..1598b82ac2 100644
--- a/builtin/stash--helper.c
+++ b/builtin/stash--helper.c
@@ -11,8 +11,15 @@
#include "dir.h"
static const char * const git_stash_helper_usage[] = {
+ N_("git stash--helper drop [-q|--quiet] [<stash>]"),
N_("git stash--helper apply [--index] [-q|--quiet] [<stash>]"),
N_("git stash--helper branch <branchname> [<stash>]"),
+ N_("git stash--helper clear"),
+ NULL
+};
+
+static const char * const git_stash_helper_drop_usage[] = {
+ N_("git stash--helper drop [-q|--quiet] [<stash>]"),
NULL
};
@@ -26,6 +33,11 @@ static const char * const git_stash_helper_branch_usage[] = {
NULL
};
+static const char * const git_stash_helper_clear_usage[] = {
+ N_("git stash--helper clear"),
+ NULL
+};
+
static const char *ref_stash = "refs/stash";
static int quiet;
static char stash_index_path[PATH_MAX];
@@ -114,6 +126,29 @@ static int get_stash_info(struct stash_info *info, const char *commit)
return 0;
}
+static int do_clear_stash(void)
+{
+ struct object_id obj;
+ if (get_oid(ref_stash, &obj))
+ return 0;
+
+ return delete_ref(NULL, ref_stash, &obj, 0);
+}
+
+static int clear_stash(int argc, const char **argv, const char *prefix)
+{
+ struct option options[] = {
+ OPT_END()
+ };
+
+ argc = parse_options(argc, argv, prefix, options, git_stash_helper_clear_usage, PARSE_OPT_STOP_AT_NON_OPTION);
+
+ if (argc != 0)
+ return error(_("git stash--helper clear with parameters is unimplemented"));
+
+ return do_clear_stash();
+}
+
static int reset_tree(struct object_id i_tree, int update, int reset)
{
struct unpack_trees_options opts;
@@ -313,6 +348,60 @@ static int apply_stash(int argc, const char **argv, const char *prefix)
return do_apply_stash(prefix, &info, index);
}
+static int do_drop_stash(const char *prefix, struct stash_info *info)
+{
+ struct argv_array args = ARGV_ARRAY_INIT;
+ int ret;
+ struct child_process cp = CHILD_PROCESS_INIT;
+
+ argv_array_pushl(&args, "reflog", "delete", "--updateref", "--rewrite", NULL);
+ argv_array_push(&args, info->revision);
+ ret = cmd_reflog(args.argc, args.argv, prefix);
+ if (!ret) {
+ if (!quiet) {
+ printf(_("Dropped %s (%s)\n"), info->revision, sha1_to_hex(info->w_commit.hash));
+ }
+ } else {
+ return error(_("%s: Could not drop stash entry"), info->revision);
+ }
+
+ cp.git_cmd = 1;
+ /* Even though --quiet is specified, rev-parse still outputs the hash */
+ cp.no_stdout = 1;
+ argv_array_pushl(&cp.args, "rev-parse", "--verify", "--quiet", NULL);
+ argv_array_pushf(&cp.args, "%s@{0}", ref_stash);
+ ret = run_command(&cp);
+
+ if (ret)
+ do_clear_stash();
+
+ return 0;
+}
+
+static int drop_stash(int argc, const char **argv, const char *prefix)
+{
+ const char *commit = NULL;
+ struct stash_info info;
+ struct option options[] = {
+ OPT__QUIET(&quiet, N_("be quiet, only report errors")),
+ OPT_END()
+ };
+
+ argc = parse_options(argc, argv, prefix, options,
+ git_stash_helper_drop_usage, 0);
+
+ if (argc == 1)
+ commit = argv[0];
+
+ if (get_stash_info(&info, commit))
+ return -1;
+
+ if (!info.is_stash_ref)
+ return error(_("'%s' is not a stash reference"), commit);
+
+ return do_drop_stash(prefix, &info);
+}
+
static int branch_stash(int argc, const char **argv, const char *prefix)
{
const char *commit = NULL, *branch = NULL;
@@ -371,6 +460,10 @@ int cmd_stash__helper(int argc, const char **argv, const char *prefix)
usage_with_options(git_stash_helper_usage, options);
else if (!strcmp(argv[0], "apply"))
result = apply_stash(argc, argv, prefix);
+ else if (!strcmp(argv[0], "clear"))
+ result = clear_stash(argc, argv, prefix);
+ else if (!strcmp(argv[0], "drop"))
+ result = drop_stash(argc, argv, prefix);
else if (!strcmp(argv[0], "branch"))
result = branch_stash(argc, argv, prefix);
else {
diff --git a/git-stash.sh b/git-stash.sh
index 360643ad4e..54d0a6c21f 100755
--- a/git-stash.sh
+++ b/git-stash.sh
@@ -716,7 +716,7 @@ apply)
;;
clear)
shift
- clear_stash "$@"
+ git stash--helper clear "$@"
;;
create)
shift
@@ -728,7 +728,7 @@ store)
;;
drop)
shift
- drop_stash "$@"
+ git stash--helper drop "$@"
;;
pop)
shift
--
2.16.2
next prev parent reply other threads:[~2018-03-24 17:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 17:37 [PATCH 0/4] Convert some stash functionality to a builtin Joel Teichroeb
2018-03-24 17:37 ` [PATCH 1/4] stash: convert apply to builtin Joel Teichroeb
2018-03-24 18:19 ` Christian Couder
2018-03-25 6:40 ` Eric Sunshine
2018-03-25 9:27 ` Christian Couder
2018-03-25 8:09 ` Christian Couder
2018-03-25 16:51 ` Joel Teichroeb
2018-03-25 19:58 ` Christian Couder
[not found] ` <20180325204653.1470-1-avarab@gmail.com>
2018-03-25 20:57 ` [PATCH] Remove contrib/examples/* Ævar Arnfjörð Bjarmason
2018-03-26 6:01 ` Jeff King
2018-03-26 20:58 ` Junio C Hamano
2018-03-25 16:43 ` [PATCH 1/4] stash: convert apply to builtin Thomas Gummerer
2018-03-28 3:30 ` Joel Teichroeb
2018-03-25 17:23 ` Thomas Gummerer
2018-03-24 17:37 ` [PATCH 2/4] stash: convert branch " Joel Teichroeb
2018-03-25 6:44 ` Eric Sunshine
2018-03-25 8:22 ` Christian Couder
2018-03-25 17:02 ` Thomas Gummerer
2018-03-24 17:37 ` Joel Teichroeb [this message]
2018-03-24 18:22 ` [PATCH 3/4] stash: convert drop and clear " Christian Couder
2018-03-25 6:49 ` Eric Sunshine
2018-03-24 17:37 ` [PATCH 4/4] stash: convert pop " Joel Teichroeb
2018-03-25 6:51 ` Eric Sunshine
2018-03-25 17:36 ` Thomas Gummerer
2018-03-25 17:39 ` [PATCH 0/4] Convert some stash functionality to a builtin Thomas Gummerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180324173707.17699-4-joel@teichroeb.net \
--to=joel@teichroeb.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).